Ticket #2120 (s2a_design_started bug) — at Version 2

Opened 16 years ago

Last modified 15 years ago

mp3 files with missing headers throws an exception

Reported by: todor Owned by:
Priority: major Milestone: M12_RELEASE
Component: uncategorized Version: 2.0
Keywords: Cc: stefan
Category: unknown Effort:
Importance: Ticket_group:
Estimated Number of Hours: 0 Add Hours to Ticket: 0
Billable?: yes Total Hours: 0
Analysis_owners: stefan Design_owners:
Imp._owners: Test_owners:
Analysis_reviewers: Changelog:
Design_reviewers: Imp._reviewers:
Test_reviewers: Analysis_score: 3
Design_score: 3 Imp._score: 3
Test_score: 0

Description (last modified by stefan) (diff)

  1. Insert an mp3 audio file.
  2. If the file is with missing or corrupted header, the media decoder native stops and throws an exception.

Fix:

  • java - in the org.sophie2.main.media.natlib.decoder.MediaNativeBridge is added if clause to check whether returned response is ErrorResponse that contains "length < 0" substring in its message, which means that the packet read from the file is corrupted (mostly the header)...
  • natives - in the media_decoder.h file in the decodeaudio3 method, the assert that used to check whether the decoding of the packet is successful is changed to if clause, and if it is corrupted/missing/ it throws an exception that is handled in the mainLoop of the native. A ErrorResponse with the exception message is returned to the java side.

A patch with the changes is added.

Change History

comment:1 Changed 16 years ago by todor

  • Status changed from new to s1b_analysis_finished

Changed 16 years ago by stefan

sample mp3 with damaged/missing header

comment:2 Changed 16 years ago by stefan

  • Status changed from s1b_analysis_finished to s2a_design_started
  • Description modified (diff)
Note: See TracTickets for help on using tickets.