Ticket #2433 (s1b_analysis_finished bug) — at Version 4

Opened 15 years ago

Last modified 13 years ago

immutable collections -- get index misbehavior

Reported by: stefan Owned by:
Priority: major Milestone:
Component: uncategorized Version: 2.0
Keywords: Cc:
Category: unknown Effort:
Importance: Ticket_group: immutable collections
Estimated Number of Hours: 0 Add Hours to Ticket: 0
Billable?: yes Total Hours: 0
Analysis_owners: stefan Design_owners:
Imp._owners: Test_owners:
Analysis_reviewers: pap Changelog: Changelog
Design_reviewers: Imp._reviewers:
Test_reviewers: Analysis_score: 3.5
Design_score: 4 Imp._score: 4
Test_score: 0

Description (last modified by stefan) (diff)

There is inconsistency with the method get(K) of ImmTreeMap class - when the provided key is missing, it throws an exception. Needed behavior is to return null.
wiki page: IMM_COLLECTIONS_REFACTOR. Review usage - calling of this method.

Change History

comment:1 Changed 15 years ago by stefan

  • Status changed from new to s1b_analysis_finished

comment:2 Changed 15 years ago by stefan

  • Ticket_group set to immutable collections
  • Description modified (diff)

comment:3 Changed 15 years ago by pap

  • Status changed from s1b_analysis_finished to new
  • Analysis_reviewers set to pap
  • Analysis_score changed from 0 to 2
  • Actually the problem is not with this method.
  • The problem is in ImmTreeMap.get(key) that throws when queried for a nonexistent key.
  • Instead of that it should return null.
  • Also it is advisable that the usages of this method are reviewed and simplified as now they all explicitly call contains. And this should be pointed as a requirement.

comment:4 Changed 15 years ago by stefan

  • Status changed from new to s1b_analysis_finished
  • Description modified (diff)
Note: See TracTickets for help on using tickets.