Ticket #578 (closed planned_task: obsolete)

Opened 14 years ago

Last modified 13 years ago

PAGE_PREVIEW_PALETTE_R0

Reported by: Astea Owned by: mitex
Priority: 3 Milestone: M04_PRE4
Component: BOOK_PAGES Version: 2.0
Keywords: Cc: mitex
Category: MAIN Effort: 3
Importance: 0 Ticket_group:
Estimated Number of Hours: 0 Add Hours to Ticket: 0
Billable?: yes Total Hours: 0
Analysis_owners: danvisel Design_owners: sveto, sveto
Imp._owners: sveto, sveto, mitex Test_owners:
Analysis_reviewers: dido Changelog:
Design_reviewers: pap,pap Imp._reviewers: pap, meddle, meddle, pap
Test_reviewers: Analysis_score: 4
Design_score: 3 Imp._score: 3
Test_score: 0

Description

wiki page: PAGE_PREVIEW_PALETTE_R0 - effort: 1.5d

Change History

comment:1 Changed 14 years ago by mira

  • Status changed from new to s1a_analysis_started
  • Analysis_score set to 0
  • Test_score set to 0
  • Design_score set to 0
  • Owner changed from Astea to mira
  • Imp._score set to 0
  • Analysis_owners set to mira

comment:2 Changed 14 years ago by mira

  • Status changed from s1a_analysis_started to s1b_analysis_finished

comment:3 Changed 14 years ago by kyli

  • Status changed from s1b_analysis_finished to s1c_analysis_ok
  • Analysis_reviewers set to kyli
  • Analysis_score changed from 0 to 4

4p. It's OK.

comment:4 Changed 14 years ago by peko

  • Design_owners set to peko
  • Owner changed from mira to peko
  • Status changed from s1c_analysis_ok to s2a_design_started

comment:5 Changed 14 years ago by peko

  • Design_owners peko deleted

comment:6 Changed 14 years ago by deyan

  • Cc mira, deyan added

Batch update from file newimport.csv

comment:7 Changed 14 years ago by deyan

  • Cc peko added; deyan removed

comment:8 Changed 14 years ago by deyan

Should we return this to analysis ok?

comment:9 Changed 14 years ago by danvisel

  • Analysis_reviewers kyli deleted
  • Analysis_owners changed from mira to danvisel
  • Analysis_score changed from 4 to 0

Reworking analysis with Sveto.

comment:10 Changed 14 years ago by dido

  • Status changed from s2a_design_started to new

comment:11 Changed 14 years ago by sveto

  • Cc sveto added; mira, peko removed
  • Effort changed from 1.5 to 3

comment:12 Changed 14 years ago by danvisel

  • Owner changed from peko to danvisel
  • Status changed from new to s1a_analysis_started

comment:13 Changed 14 years ago by danvisel

  • Status changed from s1a_analysis_started to s1b_analysis_finished

This analysis is ready to be reviewed. Time = 4h.

comment:14 Changed 14 years ago by dido

  • Status changed from s1b_analysis_finished to s1c_analysis_ok
  • Analysis_reviewers set to dido
  • Analysis_score changed from 0 to 4

If the thumbs are with fixed size for this revision, they should remain the aspect ratio of the page and fill the remaining space in the thumb with flat colour. It will be nice if its the same as page background colour or if the page background is different than flat colour we could use black or white.
analysis review 4p (1h)

comment:15 Changed 14 years ago by sveto

  • Design_owners set to sveto
  • Owner changed from danvisel to sveto
  • Status changed from s1c_analysis_ok to s2a_design_started

comment:16 Changed 14 years ago by sveto

  • Status changed from s2a_design_started to s2b_design_finished

design took 7.5h

comment:17 Changed 13 years ago by pap

  • Status changed from s2b_design_finished to s1c_analysis_ok
  • Design_score changed from 0 to 2
  • Design_reviewers set to pap
  • There are good ideas in the desin but there are things that are not good
  • I think that the PagePreviewPaletteCellRenderer is not necessary. You can use te render() method of the ListPaletteItem
  • You should use LogicR3 about the actions that the palette performs.
  • The latter gives you the ability to easily write tests, which are obligatory for designs.

comment:18 Changed 13 years ago by sveto

  • Design_owners changed from sveto to sveto, sveto
  • Status changed from s1c_analysis_ok to s2a_design_started

comment:19 Changed 13 years ago by sveto

  • Status changed from s2a_design_started to s2b_design_finished

(6h)

comment:20 Changed 13 years ago by pap

  • Status changed from s2b_design_finished to s2c_design_ok
  • Design_score changed from 2 to 3
  • Design_reviewers changed from pap to pap,pap
  • I think the design is better now, but there are things that I want to note.
  • From the tests given I get the idea that page deletion is not done with the use of MVCR3 events. It is better if you use them for such things.
  • It is good to make sure that you cannot delete pages when a book is not editable(in preview mode)
  • You should mention all major changes that you do in your design. This means that the changes to the ListPalette should be described too.
  • To make the above clearer : Design part of a wiki page includes all the changes to the project, not only the ones that are to the particular task.
  • Make sure that in the implementation section you mention what went different from what was described in the design.
  • Good luck.

comment:21 Changed 13 years ago by sveto

  • Status changed from s2c_design_ok to s3a_implementation_started

comment:22 Changed 13 years ago by sveto

  • Status changed from s3a_implementation_started to s3b_implementation_finished

(17.5h)

comment:23 Changed 13 years ago by sveto

  • Imp._owners set to sveto

comment:24 Changed 13 years ago by pap

  • Status changed from s3b_implementation_finished to s2c_design_ok
  • Imp._score changed from 0 to 2
  • Imp._reviewers set to pap
  • There is unused code that you havent cleared out.
  • You had some methods with missing javadoc
  • Ids is not a nice name. EventIds is better although even better may exist.
  • You have lots of final properties and that is bad.
  • It is better to use some auto properties in some places
  • The multiple selection of items should be available for all ListPalettes. It is not nice to do such a separete solution for each palette. You may just leave it with single selection for now.
  • Having a separate page work area for each item makes the application very slow.
  • Perhaps you may have a single page work area and make the thumbnails display only an image that is creted in the synchronizing property.

comment:25 Changed 13 years ago by sveto

  • Status changed from s2c_design_ok to s3a_implementation_started

comment:26 Changed 13 years ago by sveto

  • Imp._owners changed from sveto to sveto, sveto

comment:27 Changed 13 years ago by sveto

  • Status changed from s3a_implementation_started to s3b_implementation_finished

(9h)

comment:28 Changed 13 years ago by meddle

  • Status changed from s3b_implementation_finished to s2c_design_ok
  • Imp._score changed from 2 to 2.5
  • Imp._reviewers changed from pap to pap, meddle

I'll have to fail it because nothing can be saved with the persistence now and when you add non-text frames some times the app crashes :(

2.5p (70m)

comment:29 Changed 13 years ago by mitex

  • Status changed from s2c_design_ok to s3a_implementation_started
  • Total Hours set to 0
  • Imp._owners changed from sveto, sveto to sveto, sveto, mitex
  • Add Hours to Ticket set to 0
  • Billable? set
  • Owner changed from sveto to mitex
  • Estimated Number of Hours set to 0

comment:30 Changed 13 years ago by mitex

  • Status changed from s3a_implementation_started to s3b_implementation_finished

comment:31 Changed 13 years ago by pap

  • Cc mitex added; sveto removed
  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Imp._score changed from 2.5 to 3
  • Imp._reviewers changed from pap, meddle to pap, meddle, meddle, pap
  • Why did you use ResourceH#get(key) instead of BookH#getPages(); Why didn't you fix it???
  • Use BookViewOptions when possible. It is much lceaner than "author".equals ......
  • The buttons for adding pages were visible and enabled for preview mode books.
  • There are problems with the refreshing of the current page in the palette when its contents are changed.
  • Problems with refreshing of the palette contents in Reader.
  • Good luck.

comment:32 Changed 13 years ago by deyan

  • Status changed from s3c_implementation_ok to closed
  • Resolution set to obsolete

Batch update from file query-obsoleted.csv

Note: See TracTickets for help on using tickets.