Changes between Version 2 and Version 3 of CODE_TASKS_REQUIREMENTS

Timestamp:

09/16/08 17:52:25 (17 years ago)

Author:

Tanya

Comment:

--

CODE_TASKS_REQUIREMENTS

@@ -79 +79 @@
  * other:
   * Enough information should be provided in the backlog.
+
+= Code Reuse =
+
+Do not have the same functionality on more than one place - this increases the chances of mistakes and makes it difficult for refactor.
+
+In the class !BookView we had the following two methods:
+As we see we have code reuse, and the private method do not register the view as observer of the page.
+{{{
+        @Override
+        public void pageAdded(Page page) {              
+                PageView pageView = new PageView(this, page);
+                this.pageViews.add(pageView);
+                page.getObservable().addObserver(pageView);
+                this.observable.getInvoker().pageViewCreated(pageView);
+        }
+  
+...
+
+        private void createChildView(Page page){
+                PageView p = new PageView(this, page);
+                this.pageViews.add(p);
+                this.observable.getInvoker().pageViewCreated(p);
+        }
+}}}
+
+Shall be:
+
+{{{
+        private void createChildView(Page page){
+                final PageView p = new PageView(this, page);
+                this.pageViews.add(p);
+                this.observable.getInvoker().pageViewCreated(p);
+                page.getObservable().addObserver(p);
+        }
+
+...
+        public void pageAdded(Page page) {              
+                createChildView(page);
+        }
+}}}