[[BackLinksMenu]] [[TicketQuery(summary=PLATFORM_STANDARDS_CODE_R1, format=table, col=summary|owner|status|type|component|priority|effort|importance, rows=description|analysis_owners|analysis_reviewers|analysis_score|design_owners|design_reviewers|design_score|implementation_owners|implementation_reviewers|implementation_score|test_owners|test_reviewers|test_score|)]] = Analysis = == Overview == Better structured code standards, requirements for reviews. == Task requirements == * Create [wiki:PLATFORM_STANDARDS_CODE] * Review [wiki:PLATFORM_STANDARDS_CODE_R0] implementation section create a better structure and link the pages there in [wiki:PLATFORM_STANDARDS_CODE]. The resulting pages should be renamed to satisfy the wiki naming convention. * Define rules for reviewing coding tasks' implementation (See implementation idea) * Required section - things that are obligatory for the implementation in order to pass the review * Recommended section - things that are recommended for the implementation, needed for higher score * Optional section - things that can be included in the implementation and may be rated with higher score. These rules should be structured like a checklist. See implementation idea for more detailed information. These requirements will be updated each week when suggestions are made. * Explain when requesting a super review is allowed. * Add a requirement that the reviewer should either stick to these rules or comment them in the comment section. == Task result == [wiki:PLATFORM_STANDARDS_CODE] == Implementation idea == Expand these suggestions and add links where needed (linked rules for every requirement). {{{ Code tasks requrements: * Implementation section should contain * description of what is done * link to svn changeset or revision * The code should satisfy all of the code requirements * Unit test with good quality and enough to cover the code * reasonable javadoc everywhere * no smells * are modules done properly (if any) * does logging satisfy requirements * no system.println * at right level }}} == Related == [wiki:PLATFORM_STANDARDS_ANALYSIS] [[BR]] [wiki:PLATFORM_STANDARDS_DESIGN] [[BR]] [wiki:PLATFORM_STANDARDS_GENERAL] [[BR]] == How to demo == Present [wiki:PLATFORM_STANDARDS_CODE] explain review rules. = Design = = Implementation = ^(Implementation results should be described and linked here (from the wiki or the repository))^ = Testing = = Comments = ^(Write comments for this or later revisions here.)