| 93 | | ''To be continued..'' |
| | 93 | There is a problem with the HotLayout.dryRun() method - it can only return non-negative values or -1. The bad effect here is that the autochaining can remove only 1 area at a time, then everything must be revalidated. So, if you have a chain with 300 frames, select all the text and delete it, you will wait several tens of minutes before all the areas are removed. It can easily be fixed with little modification of the algorithm. So, do it :) |
| | 94 | |
| | 95 | Another issue appears with the search - it cannot search in invalid areas, since they have no consumed text. The only solution I can propose is to force everyone that is interested in the consumed text to validate the layout first. (Since the layout is immutable, it cannot validate itself. If we make it mutable, we will have troubles with repainting, I guess). |
| | 96 | |
| | 97 | The determination of the visible areas appeared to be a slow operation in large books. A possible optimization could be to hold the list of areas in auto-prop (HeadSceneTextView.visibleAreas() ), not in method. |
| | 98 | |
| | 99 | Segment layout caching was inspected, and the results are: |
| | 100 | * Caching the styled text throws exceptions with the HotLineLayout.getPosPlace() method - the text is visually the same, but does not contain the same positions. Make method getPosPlace(int index) in HotSegmentLayout, so that the position will be turned into real index before calling this method. |
| | 101 | * Caching cannot currently work, because getStyledHash() in ImmHotText does not work correctly. It will be fixed with TEXT_MODEL_INTERNAL task. Until then, the written lines about segment caching could stay commented. |
| | 102 | |
| | 103 | Unit tests: |
| | 104 | * HotLayout.getStatus() is tested in []. |
| | 105 | * BackgroundThread is tested in []. |
