Changes between Version 3 and Version 4 of UNPLANNED_LOGIC_REFACTORING_R0

Timestamp:

08/20/09 20:12:47 (16 years ago)

Author:

mitex

Comment:

--

UNPLANNED_LOGIC_REFACTORING_R0

@@ -11 +11 @@
   * Menu items have {{{clicked}}} method instead of firing an R3 event. For some items it is trivial to switch to R3 Logic.
    * Not all menu items will be refactored.
+  * Code duplication due to copy-paste.
  * No new functionality is going to be added.
 
@@ -21 +22 @@
  * For halo buttons, extract logics and group them by functionality.
   * For example, create {{{org.sophie2.main.app.halos.grouping.GroupHalosLogic}}} which handles events from all halo buttons related to grouping.
+ * Refactor the align buttons: Reuse the code where possible.
  * In menu items deprecate the method {{{clicked}}}.
   * Create a new event CLICKED that should be fired when a menu item is clicked.
@@ -39 +41 @@
 
 = Design =
-^(Describe your design here.)^
+ * For the align buttons:
+  * Create two abstract methods in AlignElementsButton:
+   * {{{float calculateAlignValue(List<ElementView> selected)}}} - for a given list of element views calculates some align value, for example, the Y-axis of the top-most element.
+   * {{{ImmPoint calculateNewLocation(ImmRect bounds, float alignValue)}}} - calculates a new location for a single element, given the old bounds and the align value, returned from the above method.
+  * Replace the {{{clicked}}} method in all align buttons with the above methods.
+  * Create {{{AlignElementsLogic}}} with a single handler - {{{ON_ALIGN}}}, which listens for {{{CLICKED}}} from {{{AlignElementsButton}}}.
+   * Calculates the align value
+   * Creates an immutable list of new locations
+   * Creates an immutable list of references to elements. Only elements of type {{{MemberElement}}} are collected.
+   * Creates a new {{{AutoAction}}} that iterates over all references and changes {{{MemberElement.KEY_LOCATION}}} with the newly calculated location.
 
 = Implementation =