Ticket #1038 (closed planned_task: obsolete)
BROWSER_CONTENT_BASIC_R0
| Reported by: | Astea | Owned by: | nenko |
|---|---|---|---|
| Priority: | 3 | Milestone: | M05_PRE5 |
| Component: | COMPOSITE_ELEMENTS | Version: | 2.0 |
| Keywords: | Cc: | tanya | |
| Category: | EXTRA | Effort: | 2 |
| Importance: | 0 | Ticket_group: | |
| Estimated Number of Hours: | Add Hours to Ticket: | ||
| Billable?: | Total Hours: | ||
| Analysis_owners: | todor | Design_owners: | tanya, nenko |
| Imp._owners: | tanya, nenko | Test_owners: | |
| Analysis_reviewers: | dido | Changelog: | |
| Design_reviewers: | meddle, meddle | Imp._reviewers: | pap |
| Test_reviewers: | Analysis_score: | 3.5 | |
| Design_score: | 4 | Imp._score: | 3 |
| Test_score: | 0 |
Description
wiki page: BROWSER_CONTENT_BASIC_R0 - effort: 2d
Change History
comment:1 Changed 16 years ago by todor
- Status changed from new to s1a_analysis_started
- Analysis_score set to 0
- Test_score set to 0
- Design_score set to 0
- Owner changed from Astea to todor
- Imp._score set to 0
- Analysis_owners set to todor
comment:2 Changed 16 years ago by todor
- Status changed from s1a_analysis_started to s1b_analysis_finished
done
comment:3 Changed 16 years ago by dido
- Status changed from s1b_analysis_finished to s1c_analysis_ok
- Analysis_score changed from 0 to 3.5
We have to provide additional documentation for this frame, what could be displayed and what won't. Also I expect this to be 3rd party library, witch use some of the existing popular browsers. Some questions remains opened - will it read css files, flash content etc.?
Analysis review 3.5p (1h)
comment:5 Changed 16 years ago by tanya
- Owner changed from todor to tanya
- Status changed from s1c_analysis_ok to s2a_design_started
comment:6 Changed 16 years ago by tanya
- Design_owners set to tanya
- Status changed from s2a_design_started to s2b_design_finished
- Imp._owners set to tanya
comment:7 Changed 16 years ago by meddle
- Cc tanya added
- Design_score changed from 0 to 2
- Design_reviewers set to meddle
- Status changed from s2b_design_finished to s1c_analysis_ok
I can't pass that design, it is too unclear.
- Describe this BrowserResource of yours, what it will contain, I took a look at your implementation and saw that it's empty Resource... But it must have the URL in it, the url will be persistable after all. Your URL is in the content...
- What will be the icon for your Halo?
- The design describes and the technologies you will use and how you will fight the problems and the hard stuff that their usage arises...
2p (20m)
comment:8 Changed 16 years ago by meddle
I talked with Milo, so you can proceed using the url in the content, but the Resource for the browser is not needed. Remove it, it is possible to have contents without main Resource when it has no meaning.
comment:9 Changed 16 years ago by nenko
- Design_owners changed from tanya to tanya, nenko
- Owner changed from tanya to nenko
- Status changed from s1c_analysis_ok to s2a_design_started
comment:10 Changed 16 years ago by nenko
- Status changed from s2a_design_started to s2b_design_finished
comment:11 Changed 16 years ago by meddle
- Status changed from s2b_design_finished to s2c_design_ok
- Design_score changed from 2 to 4
- Design_reviewers changed from meddle to meddle, meddle
OK now the design passes :) If you take the other task with the interactions on the browser frame it will be great.
4p (50m)
comment:12 Changed 16 years ago by nenko
- Status changed from s2c_design_ok to s3a_implementation_started
comment:13 Changed 16 years ago by nenko
- Status changed from s3a_implementation_started to s3b_implementation_finished
- Imp._owners changed from tanya to tanya, nenko
The interactions are missing. The only thing added is that the browser frame is redrawn 15 times in a second...
comment:14 Changed 16 years ago by pap
- Status changed from s3b_implementation_finished to s3c_implementation_ok
- Imp._score changed from 0 to 3
- Imp._reviewers set to pap
- It is good that we have this new functionality but there were some serious issues.
- First you didn't implement persistence and that is not so hard.
- Second in lots of places you used a very bad practice - writing try/catch(NullPointerException) instead of just checking for nulls.
- You had commented out code on several places.
- Also you had an interesting name of a variable - insertPdfItem :)
- Also the derive method of the BrowserFrameContent class didn't actually derive the URL
comment:15 Changed 15 years ago by deyan
- Status changed from s3c_implementation_ok to closed
- Resolution set to obsolete
Batch update from file query-obsoleted.csv
taken