Ticket #1175 (closed planned_task: obsolete)

Opened 14 years ago

Last modified 13 years ago

SCRIPTING_ACTIONS_API_R0

Reported by: Astea Owned by: mitex
Priority: 3 Milestone: M06_ALPHA1
Component: SCRIPTING Version: 2.0
Keywords: scripting, api, javascript Cc:
Category: EXTRA Effort: 1
Importance: 0 Ticket_group:
Estimated Number of Hours: Add Hours to Ticket:
Billable?: Total Hours:
Analysis_owners: deni, mitex Design_owners: deni, mitex
Imp._owners: deni, mitex Test_owners:
Analysis_reviewers: meddle Changelog:
Design_reviewers: kyli, meddle Imp._reviewers: meddle
Test_reviewers: Analysis_score: 3.5
Design_score: 3.5 Imp._score: 3.5
Test_score: 0

Description

wiki page: SCRIPTING_ACTIONS_API_R0 - effort: 1d

Change History

comment:1 Changed 13 years ago by dido

  • Status changed from new to s1a_analysis_started
  • Analysis_score set to 0
  • Test_score set to 0
  • Design_score set to 0
  • Owner changed from Astea to dido
  • Imp._score set to 0
  • Analysis_owners set to dido, deni

comment:2 Changed 13 years ago by dido

  • Analysis_owners changed from dido, deni to dido, deni, mitex

comment:3 Changed 13 years ago by dido

  • Status changed from s1a_analysis_started to new

comment:4 Changed 13 years ago by dido

  • Analysis_owners dido, deni, mitex deleted

comment:5 Changed 13 years ago by dido

Wrong ticket for the current analysis in the wiki page

comment:6 Changed 13 years ago by mitex

  • Keywords scripting, api, javascript added
  • Owner changed from dido to mitex
  • Status changed from new to s1a_analysis_started
  • Analysis_owners set to mitex

comment:7 Changed 13 years ago by mitex

  • Analysis_owners changed from mitex to deni, mitex

comment:8 Changed 13 years ago by mitex

  • Status changed from s1a_analysis_started to s1b_analysis_finished

comment:9 Changed 13 years ago by meddle

  • Status changed from s1b_analysis_finished to s1c_analysis_ok
  • Analysis_reviewers set to meddle
  • Analysis_score changed from 0 to 3.5

I think it passes :)

3.5p (15m)

comment:10 Changed 13 years ago by mitex

  • Status changed from s1c_analysis_ok to s2a_design_started

comment:11 Changed 13 years ago by mitex

  • Design_owners set to deni, mitex
  • Imp._owners set to deni, mitex

comment:12 Changed 13 years ago by mitex

  • Status changed from s2a_design_started to s2b_design_finished

comment:13 follow-up: ↓ 15 Changed 13 years ago by kyli

  • Status changed from s2b_design_finished to s1c_analysis_ok
  • Design_score changed from 0 to 2.5
  • Design_reviewers set to kyli

I like the design. However, some problems need to be resolved:

  • The link configuration panel does not need @Own-ed auto prop - it is pointless. Just remove it.
  • Link actions generally need to be persisted (there is such a bug reported, but maybe it would be good to create one in this task). A simple example for action persister: ToggleFrameActionPersister.
  • The most problematic according to me is that the design is missing some points. There are lots of script actions exposed in the task requirements, but only title and newBook are designed. Even if the rest will be done in a similar manner, I think they need to be mentioned. Furthermore, there are several actions (like reorder pages or remove page) which cannot be just exposed to the API (because they do not exist).
  • Please consider the setBook(ResourceRef) method.. do we need it? I mean, isn't it a better idea to make this reference constant? If else, how will you pass a concrete ResourceRef to the method..
  • The tests could be more complete. It would be cool if you test some more script actions, class exposure, and probably action persister.

comment:14 Changed 13 years ago by mitex

  • Status changed from s1c_analysis_ok to s2a_design_started

comment:15 in reply to: ↑ 13 Changed 13 years ago by mitex

The @Own annotation is required for the parent property to be set.

comment:16 Changed 13 years ago by mitex

  • Status changed from s2a_design_started to s2b_design_finished

comment:17 Changed 13 years ago by meddle

  • Status changed from s2b_design_finished to s2c_design_ok
  • Design_score changed from 2.5 to 3.5
  • Design_reviewers changed from kyli to kyli, meddle

All the wanted things from the previous review are ok except the undoable and wrong ones :)

3.5p (20m)

comment:18 Changed 13 years ago by mitex

  • Status changed from s2c_design_ok to s3a_implementation_started

comment:19 Changed 13 years ago by mitex

  • Status changed from s3a_implementation_started to s3b_implementation_finished

comment:20 Changed 13 years ago by meddle

  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Imp._score changed from 0 to 3.5
  • Imp._reviewers set to meddle

So... There were some problems I and mitex fixed them... but:

  • We should have a discussion about the behavior of the scripts in preview mode and in the reader.
  • Be careful what you expose.
  • The Desktop book should have limited scripts, for example no adding of new pages allowed.
  • I don't like your discipline mitex, it's impediment for me as your team leader.
  • The implementation I think is great, but had some problems (like the scripts staying after the book was closed, I talked to you about that several times) so:

3.5p (200m - fixing the strange bug with the preview took me a lot of time)

comment:21 Changed 13 years ago by deyan

  • Status changed from s3c_implementation_ok to closed
  • Resolution set to obsolete

Batch update from file query-obsoleted.csv

Note: See TracTickets for help on using tickets.