Ticket #118 (closed planned_task: obsolete)

Opened 14 years ago

Last modified 13 years ago

PLUGIN_SUPPORT_LIB_CONFIGURING_R1

Reported by: Astea Owned by: mitex
Priority: 3 Milestone: M06_ALPHA1
Component: PLUGIN_ARCHITECTURE Version: 2.0
Keywords: configuration file, persistence of configuration Cc:
Category: PLATFORM Effort: 1
Importance: 0 Ticket_group:
Estimated Number of Hours: Add Hours to Ticket:
Billable?: Total Hours:
Analysis_owners: mitex Design_owners: mitex
Imp._owners: mitex Test_owners:
Analysis_reviewers: dido Changelog:
Design_reviewers: meddle Imp._reviewers: meddle
Test_reviewers: Analysis_score: 3.5
Design_score: 3.5 Imp._score: 3
Test_score: 0

Description

wiki page: PLUGIN_SUPPORT_LIB_CONFIGURING_R1 - effort: 1d

Change History

comment:1 Changed 13 years ago by pav

  • Design_score set to 0
  • Ticket_group set to GROUP_PLUGINS_HOT_ENABLE_R0
  • Imp._score set to 0
  • Test_score set to 0
  • Analysis_score set to 0

comment:2 Changed 13 years ago by pav

  • Ticket_group GROUP_PLUGINS_HOT_ENABLE_R0 deleted

comment:3 Changed 13 years ago by pav

  • Ticket_group set to GROUP_PLUGINS_HOT_ENABLE_R0

comment:4 Changed 13 years ago by mitex

  • Keywords configuration file, persistence of configuration added
  • Owner changed from Astea to mitex
  • Status changed from new to s1a_analysis_started
  • Analysis_owners set to mitex
  • Ticket_group GROUP_PLUGINS_HOT_ENABLE_R0 deleted

detaching from GROUP_PLUGINS_HOT_ENABLE_R0
analysis started

comment:5 Changed 13 years ago by mitex

  • Status changed from s1a_analysis_started to s1b_analysis_finished

comment:6 Changed 13 years ago by dido

  • Status changed from s1b_analysis_finished to s1c_analysis_ok
  • Analysis_reviewers set to dido
  • Analysis_score changed from 0 to 3.5

Think that when I open the application it should be skinned with the skin that I had when I closed it last time. So what will happen, if I configure to use the default skin and then change the application look from the file menu. My opinion is that this property should not be introduced to the user in the configure palette, but I could be wrong about it.
In the task requirements section it's stated that this task should produce convention about configuration files after this part of the convention is stated. Isn't it supposed to be part of the design or implementation idea?
Analysis review 3.5p (1h)

comment:7 Changed 13 years ago by mitex

  • Design_owners set to mitex
  • Status changed from s1c_analysis_ok to s2a_design_started

comment:8 Changed 13 years ago by mitex

  • Status changed from s2a_design_started to s2b_design_finished
  • Imp._owners set to mitex

comment:9 Changed 13 years ago by meddle

  • Status changed from s2b_design_finished to s2c_design_ok
  • Design_score changed from 0 to 3.5
  • Design_reviewers set to meddle

I think the design passes but with the following notes:

  • When you use objects for expected in your tests use references to set and assert them.
  • The schema for the Persisters you use is part of the design, think of it when you design!
  • Read dido's comment and may be discuss with him. Discussing with the analysis people is important.
  • You have knowledge of UML, so why don't you put some diagram, you will help us reviewing and you will help yourself, because the review will pass faster...

3.5p (1h)

comment:10 Changed 13 years ago by mitex

  • Status changed from s2c_design_ok to s3a_implementation_started

comment:11 Changed 13 years ago by mitex

  • Status changed from s3a_implementation_started to s3b_implementation_finished

comment:12 Changed 13 years ago by meddle

  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Imp._score changed from 0 to 3
  • Imp._reviewers set to meddle
  • Code notes:
    • When you use objects for expected in your tests use references to set and assert them. That is comment comming form the design...
    • The arguments of the assertEquals test method have special meaning! The first one is the EXPECTED one, the second, the ACTUAL one. But you have only one such mistake :)
    • In the persisters you copy-paste too much, I can see comments from Milo... :)
    • The ConfigurationManagerTest is without any meaning and it is copy-pasted from the ConfigurationTest...
  • Configuration notes:
    • You MUST run your code through the true runners!
    • You forget to add the org.sophie2.base.config module to the bundle configurations of the reader and the author!


3p (85m)

comment:13 Changed 13 years ago by deyan

  • Status changed from s3c_implementation_ok to closed
  • Resolution set to obsolete

Batch update from file query-obsoleted.csv

Note: See TracTickets for help on using tickets.