Ticket #1214 (closed planned_task: obsolete)

Opened 12 years ago

Last modified 11 years ago

S2S_WEB_RESOURCE_MANIPULATION_R0

Reported by: Astea Owned by: tsachev
Priority: 3 Milestone: M05_PRE5
Component: S2S_WEB_UI Version: 2.0
Keywords: Cc:
Category: S2S Effort: 3
Importance: 0 Ticket_group:
Estimated Number of Hours: Add Hours to Ticket:
Billable?: Total Hours:
Analysis_owners: tsachev, dido Design_owners: tsachev
Imp._owners: tsachev Test_owners: tsachev
Analysis_reviewers: deyan Changelog:
Design_reviewers: meddle, meddle Imp._reviewers: meddle
Test_reviewers: Analysis_score: 3
Design_score: 4 Imp._score: 3
Test_score: 0

Description

wiki page: S2S_WEB_RESOURCE_MANIPULATION_R0 - effort: 3d

Change History

comment:1 Changed 12 years ago by pav

  • Design_score set to 0
  • Ticket_group set to GROUP_S2S_RESOURCES_R0
  • Imp._score set to 0
  • Test_score set to 0
  • Analysis_score set to 0

comment:2 Changed 12 years ago by pav

  • Ticket_group changed from GROUP_S2S_RESOURCES_R0 to GROUP_S2S_RESOURCES_R1

comment:3 Changed 12 years ago by dido

  • Owner changed from Astea to dido
  • Status changed from new to s1a_analysis_started
  • Analysis_owners set to tsachev, dido

comment:4 Changed 12 years ago by dido

  • Status changed from s1a_analysis_started to s1b_analysis_finished

analysis 2h

comment:5 Changed 12 years ago by deyan

  • Status changed from s1b_analysis_finished to s1c_analysis_ok
  • Analysis_score changed from 0 to 3

List should allow filtering. Will editing be available only by applet? It is not clear, even it is not part of this revision. The overview of R0 should be more detailed.

comment:6 Changed 12 years ago by dido

There should be a detailed view section that allows the user to edit some of the listed meta data. Editing resource it self could happen if the user download it or via applet. Also another way to edit resource is to reach it from the application without using the site. This comment will be added in the comments section.

comment:7 Changed 12 years ago by dido

  • Analysis_reviewers set to deyan

comment:8 Changed 12 years ago by dido

  • Status changed from s1c_analysis_ok to new

comment:9 Changed 12 years ago by deyan

  • Status changed from new to s1c_analysis_ok

comment:10 Changed 12 years ago by tsachev

  • Design_owners set to tsachev
  • Owner changed from dido to tsachev
  • Status changed from s1c_analysis_ok to s2a_design_started

comment:11 Changed 12 years ago by tsachev

  • Status changed from s2a_design_started to s2b_design_finished

comment:12 Changed 12 years ago by meddle

  • Ticket_group GROUP_S2S_RESOURCES_R1 deleted

comment:13 Changed 12 years ago by meddle

  • Status changed from s2b_design_finished to s1c_analysis_ok
  • Design_score changed from 0 to 2.5
  • Design_reviewers set to meddle

For the design phase is important the object model and the tests to be presented, because otherwise the review will be bad. In other hand on your picture that path /tmp/Book A is strange to me, that is a relative url or? Because this paths in the client before saving the resources are different story from these on the server. Other thing there will be something like a service that will be possible by given url of resource as a parameter to get the resource. Is it right to use the resource url for web manipulation? Wouldn't it be better if we use some other service that takes as parameter a relative path to the resource and redirects to this resources.jsp? I will be happy to have a discussion with you and may be Kyli, Boyan, Pap and Milo about that things before the next review.

2.5p (40m)

comment:14 Changed 12 years ago by tsachev

  • Status changed from s1c_analysis_ok to s2a_design_started

comment:15 Changed 12 years ago by tsachev

  • Status changed from s2a_design_started to s2b_design_finished

comment:16 Changed 12 years ago by meddle

  • Status changed from s2b_design_finished to s2c_design_ok
  • Design_score changed from 2.5 to 4
  • Design_reviewers changed from meddle to meddle, meddle

I think the design passes, don't forget to fix all the javadoc and logging for the implementation to pass our standards.

4p (10m)

comment:17 Changed 12 years ago by tsachev

  • Status changed from s2c_design_ok to s3a_implementation_started

comment:18 Changed 12 years ago by tsachev

  • Status changed from s3a_implementation_started to s3b_implementation_finished

comment:19 Changed 12 years ago by meddle

  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Imp._score changed from 0 to 3
  • Imp._reviewers set to meddle

Hmm the implementation is OK:

  • Name your test classes *Test and not *Tests.
  • One of your tests fails... ResourcesHandlerTest#testHandleDownload fails because it can not find it's resource, the book, but the web interface is working with this usecase... Try to fix it to work, because all the tests must pass on the implementation review.

3p (210m)

comment:20 Changed 12 years ago by tsachev

  • Status changed from s3c_implementation_ok to s4a_test_started

comment:21 Changed 12 years ago by tsachev

  • Status changed from s4a_test_started to s4b_test_finished

comment:22 Changed 12 years ago by tsachev

  • Imp._owners set to tsachev

comment:23 Changed 12 years ago by tsachev

  • Test_owners set to tsachev

comment:24 Changed 11 years ago by deyan

  • Status changed from s4b_test_finished to closed
  • Resolution set to obsolete

Batch update from file query-obsoleted.csv

Note: See TracTickets for help on using tickets.