Ticket #1654 (closed unplanned_task: obsolete)

Opened 14 years ago

Last modified 13 years ago

GROUP_EMBEDDED_BOOKS_R0

Reported by: boyan Owned by: mira
Priority: major Milestone: M06_ALPHA1
Component: COMPOSITE_ELEMENTS Version: 2.0
Keywords: Cc:
Category: EXTRA Effort: 0
Importance: Ticket_group:
Estimated Number of Hours: Add Hours to Ticket:
Billable?: Total Hours:
Analysis_owners: boyan Design_owners: mira
Imp._owners: mira Test_owners:
Analysis_reviewers: pav, kyli Changelog:
Design_reviewers: meddle Imp._reviewers: meddle
Test_reviewers: Analysis_score: 3.5
Design_score: 3 Imp._score: 3.5
Test_score: 0

Change History

comment:1 Changed 14 years ago by boyan

  • Status changed from new to s1a_analysis_started
  • Analysis_owners set to boyan

starting analysis

comment:2 Changed 14 years ago by boyan

  • Status changed from s1a_analysis_started to s1b_analysis_finished

done in 2h

comment:3 Changed 14 years ago by pav

  • Status changed from s1b_analysis_finished to new
  • Analysis_reviewers set to pav
  • Analysis_score changed from 0 to 2.5

According to specification you should add in the overview that the user can add embedded book adding a book in the Contents folder(then it shows in the embedded books palette). The page palette should be syncronized to show the pages of embedded book when it is on focus.

comment:4 Changed 14 years ago by boyan

  • Status changed from new to s1a_analysis_started

starting analysis again

comment:5 Changed 14 years ago by boyan

  • Status changed from s1a_analysis_started to s1b_analysis_finished

The specification about the Contents folder is deprecated (it is related to Sophie 1 books). Some other minor things changed. (30m)

comment:6 Changed 14 years ago by kyli

  • Status changed from s1b_analysis_finished to s1c_analysis_ok
  • Analysis_reviewers changed from pav to pav, kyli
  • Analysis_score changed from 2.5 to 3.5

3.5p Added a link to the Embedded books specification - it is obsolete, but still very useful. From the analysis it didn't get clear to me what is the internal difference between fully embeded book and linked - if it is not defined yet, it should be a task requirement maybe.

comment:7 Changed 14 years ago by boyan

  • Design_owners set to boyan
  • Status changed from s1c_analysis_ok to s2a_design_started

starting design

comment:8 Changed 14 years ago by boyan

  • Status changed from s2a_design_started to s2b_design_finished

finished design

comment:9 Changed 14 years ago by meddle

  • Status changed from s2b_design_finished to s1c_analysis_ok
  • Design_score changed from 0 to 2
  • Design_reviewers set to meddle

There are many unclear things in the design, many of the dependencies like the persistence are not mentioned. An embedded book can not be created in another book... That usecase and if it's even possible must be described. And the cyclic dependencies need design discussions. 2p (30m)

comment:10 Changed 14 years ago by deyan

  • Cc boyan added

Batch update from file import.csv

comment:11 Changed 14 years ago by boyan

  • Cc boyan removed

unmarking cc field

comment:12 Changed 14 years ago by mira

  • Design_owners changed from boyan to mira
  • Owner changed from boyan to mira
  • Status changed from s1c_analysis_ok to s2a_design_started

comment:13 Changed 14 years ago by mira

  • Status changed from s2a_design_started to s2b_design_finished

comment:14 Changed 14 years ago by meddle

  • Status changed from s2b_design_finished to s2c_design_ok
  • Design_score changed from 2 to 3

I'll pass the design, but next time I WANT design related code at the design phase, and I'll fail for that reason!

  • The java assertations in the JUnit tests are strange, Use assertTrue or assertFalse.
  • Bad spacing.
  • That design is bad documentation, it's more like scenario to me.

3p (25m)

comment:15 Changed 14 years ago by mira

  • Status changed from s2c_design_ok to s3a_implementation_started

comment:16 Changed 14 years ago by mira

  • Status changed from s3a_implementation_started to s3b_implementation_finished

comment:17 Changed 14 years ago by mira

  • Imp._owners set to mira

comment:18 Changed 14 years ago by meddle

  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Imp._score changed from 0 to 3.5
  • Imp._reviewers set to meddle
  • Code related notes:
    • Use assertNotNull for asserting that something is not null.
    • Malformed JavaDocs :(
    • And again... spacing.

3.5p (40m)

comment:19 Changed 13 years ago by deyan

  • Status changed from s3c_implementation_ok to closed
  • Resolution set to obsolete

Batch update from file query-obsoleted.csv

Note: See TracTickets for help on using tickets.