Ticket #1702 (closed bug: fixed)

Opened 10 years ago

Last modified 10 years ago

Page resize halo placed incorrectly

Reported by: deyan Owned by: deni
Priority: major Milestone: M09_BETA1
Component: PAGE_PROPERTIES Version: 2.0
Keywords: Cc: deni
Category: unknown Effort:
Importance: Ticket_group:
Estimated Number of Hours: Add Hours to Ticket:
Billable?: Total Hours:
Analysis_owners: deyan Design_owners: deni
Imp._owners: deni Test_owners:
Analysis_reviewers: pap Changelog:
Design_reviewers: pap Imp._reviewers: pap
Test_reviewers: Analysis_score: 3.5
Design_score: 3.5 Imp._score: 3.5
Test_score: 3.5

Description

The page resize halo is not placed correctly when bottom and right border widths are set to 0.

Change History

comment:1 Changed 10 years ago by deyan

  • Owner changed from pap to deyan
  • Status changed from new to s1a_analysis_started

comment:2 Changed 10 years ago by deyan

  • Status changed from s1a_analysis_started to s1b_analysis_finished
  • Analysis_owners set to deyan

comment:3 Changed 10 years ago by deni

  • Status changed from s1b_analysis_finished to s1c_analysis_ok

comment:4 Changed 10 years ago by deni

  • Owner changed from deyan to deni
  • Status changed from s1c_analysis_ok to s2a_design_started

comment:5 follow-up: ↓ 6 Changed 10 years ago by deni

  • Status changed from s2a_design_started to s2b_design_finished

comment:6 in reply to: ↑ 5 Changed 10 years ago by deni

Replying to deni:
The halo's location (top left corner) should be determined by the page size.
Its coordinates in the page are (pageSize.getWidth(), pageSize.getHeight()).
They should be converted from page to scene coordinates, so that it works with zoom.
After that they should be converted to swing coordinates.

comment:7 Changed 10 years ago by deni

  • Status changed from s2b_design_finished to s2c_design_ok

comment:8 Changed 10 years ago by deni

  • Status changed from s2c_design_ok to s3a_implementation_started

comment:9 Changed 10 years ago by deni

  • Status changed from s3a_implementation_started to s3b_implementation_finished

Changeset: [3576]

comment:10 Changed 10 years ago by pap

  • Design_owners set to deni
  • Status changed from s3b_implementation_finished to closed
  • Imp._owners set to deni
  • Analysis_reviewers set to pap
  • Analysis_score changed from 0 to 3.5
  • Imp._reviewers set to pap
  • Design_score changed from 0 to 3.5
  • Design_reviewers set to pap
  • Resolution set to fixed
  • Imp._score changed from 0 to 3.5
  • The fix is ok but you use bad variable naming. For sure the name "l" means totally nothing.
  • Commmited into trunk in [3695]

comment:11 Changed 10 years ago by pap

  • Cc deni, deyan added; pap removed

adding cc

comment:12 Changed 10 years ago by deyan

  • Cc deyan removed
  • Test_score changed from 0 to 3.5

Tested in [3717]

Note: See TracTickets for help on using tickets.