Ticket #1705 (closed bug: fixed)

Opened 10 years ago

Last modified 10 years ago

TLID:788 When a page has image background, it can't be saved

Reported by: deyan Owned by: deni
Priority: critical Milestone: M09_BETA1
Component: uncategorized Version: 2.0
Keywords: Cc:
Category: unknown Effort:
Importance: Ticket_group:
Estimated Number of Hours: Add Hours to Ticket:
Billable?: Total Hours:
Analysis_owners: deyan Design_owners: deni
Imp._owners: deni Test_owners:
Analysis_reviewers: meddle Changelog:
Design_reviewers: meddle Imp._reviewers: meddle
Test_reviewers: deyan Analysis_score: 3.5
Design_score: 3.5 Imp._score: 3.5
Test_score: 3.5

Description (last modified by deyan) (diff)

  1. Open Page Appearence halo. Choose an image for page background.
  1. Save and reload the book.
  1. Insert a frame. Open frame appearence halo. Choose an image for background.
  1. Save and reload the book.


  1. The image is applied as background immidiately.
  1. The book is saved and reloaded with the image as page backround.
  1. The image is applied as background immidiately.
  1. The book is saved and reloaded with the images as page and frame backround.

Fails at step 2. See attached report.

Attachments

background.txt (6.2 KB) - added by deyan 10 years ago.
background.sjrb (1.8 KB) - added by deyan 10 years ago.

Change History

comment:1 Changed 10 years ago by deyan

  • Owner set to deyan
  • Status changed from new to s1a_analysis_started
  • Description modified (diff)

comment:2 Changed 10 years ago by deyan

  • Status changed from s1a_analysis_started to s1b_analysis_finished

Changed 10 years ago by deyan

comment:3 Changed 10 years ago by deyan

The book is actualy saved, but when tried to load it, another error appeared. Attached the book also

Changed 10 years ago by deyan

comment:4 Changed 10 years ago by deyan

  • Priority changed from major to critical

comment:5 Changed 10 years ago by deni

  • Status changed from s1b_analysis_finished to s1c_analysis_ok

comment:6 Changed 10 years ago by deni

  • Owner changed from deyan to deni
  • Status changed from s1c_analysis_ok to s2a_design_started

comment:7 Changed 10 years ago by deni

  • Design_owners set to deni
  • Status changed from s2a_design_started to s2b_design_finished
  • In BackgroundStyle change the type of background image property from ImmImage to ResourceRef.
  • In BackgroundImageField create a new ImageResource with an appropriate parent - the frame or the page whose background will be changed.
  • Add a new method in BackgroundAndBorderHud - public Prop<Resource> resourceModel() which returns the frame or page whose bachground will be changed
  • Add a new method in BackgroundDialogField - protected Resource getResourceModel() which will be used in BackgroundImageField.
  • The background image will be persisted by ResourcePersister after its parent resource (the frame or page) is persisted.
  • In BackgroundStylePersister persist only the ResourceRef, pointing to the image resource.
  • Refactor BackgroundStylePersister to persist only what is necessary. For example if the user has chosen an image and then changes it to a colour, only the colour should be persisted (even though the BackgroundStyle object still contains information about the image).

comment:8 Changed 10 years ago by deni

  • In BackgroundStyle replace the RWProperty for pattern with an AutoProperty depending on bgImageResource.
  • In ResourceLocalCache use ProLists instead of HashMaps for locationResourceMap and entityIdResourceMap. In this way if we have an AutoProperty depending on a ResourceRef, it will be recalculated every time the resource to which our reference points changes.

comment:9 Changed 10 years ago by deni

  • Status changed from s2b_design_finished to s2c_design_ok

comment:10 Changed 10 years ago by deni

  • Status changed from s2c_design_ok to s3a_implementation_started
  • Imp._owners set to deni

comment:11 Changed 10 years ago by deni

  • Status changed from s3a_implementation_started to s3b_implementation_finished

Chnageset: [3643]

comment:12 Changed 10 years ago by meddle

  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Analysis_reviewers set to meddle
  • Analysis_score changed from 0 to 3.5
  • Imp._reviewers set to meddle
  • Design_score changed from 0 to 3.5
  • Design_reviewers set to meddle
  • Imp._score changed from 0 to 3.5

Integrated into the trunk in [3687].

  • Additional fixes:
  • Notes:
    • Use the get method of the ResourceRef with it's second argument.

comment:13 Changed 10 years ago by meddle

  • Status changed from s3c_implementation_ok to closed
  • Resolution set to fixed

comment:14 Changed 10 years ago by meddle

Postfix : Moved the image resource persister where is the resource itself placed [3691]

comment:15 Changed 10 years ago by deyan

  • Test_score changed from 0 to 3.5
  • Test_reviewers set to deyan

Works in [3717]

Note: See TracTickets for help on using tickets.