Ticket #1725 (closed bug: fixed)

Opened 10 years ago

Last modified 10 years ago

Error when saving book with video (filename with space)

Reported by: deyan Owned by: sriggins
Priority: critical Milestone: M09_BETA1
Component: uncategorized Version: 2.0
Keywords: Cc:
Category: unknown Effort:
Importance: Ticket_group:
Estimated Number of Hours: Add Hours to Ticket:
Billable?: Total Hours:
Analysis_owners: deyan Design_owners: sriggins
Imp._owners: sriggins Test_owners:
Analysis_reviewers: meddle Changelog:
Design_reviewers: meddle Imp._reviewers: meddle
Test_reviewers: dido Analysis_score: 3.5
Design_score: 3.5 Imp._score: 3.5
Test_score: 0

Description

Create a new book, insert a video frame, save the book as, an error appears

Attachments

videobug.txt (1.6 MB) - added by deyan 10 years ago.
demo video.avi (1.5 MB) - added by deyan 10 years ago.

Change History

Changed 10 years ago by deyan

comment:1 Changed 10 years ago by deyan

  • Owner set to deyan
  • Status changed from new to s1a_analysis_started

comment:2 Changed 10 years ago by deyan

  • Priority changed from major to critical
  • Status changed from s1a_analysis_started to s1b_analysis_finished

Changed 10 years ago by deyan

comment:3 Changed 10 years ago by deyan

Happens when the videofile has space in it's name.

comment:4 Changed 10 years ago by deyan

  • Summary changed from Error when saving book with video to Error when saving book with video (filename with space)

comment:5 Changed 10 years ago by deyan

Seems to happen with audio too.

comment:6 Changed 10 years ago by sriggins

The movie is indeed copied, and encoded, but the folder the resource creates is not encoded

comment:7 Changed 10 years ago by sriggins

File in the file system is:

/var/folders/IY/IYc9-0-WHNKv-n6jayvDRE+++TI/-Tmp-/tempFile5740849472677483542demo%20video.avi

but in the url it is:

/var/folders/IY/IYc9-0-WHNKv-n6jayvDRE+++TI/-Tmp-/tempFile5740849472677483542demo%2520video.avi

with the difference being that the %20 changed to %2520

comment:8 Changed 10 years ago by sriggins

  • Status changed from s1b_analysis_finished to s1c_analysis_ok

BinDataSource>>createFile toURI converts the %20 in the existing URL to %2520

comment:9 Changed 10 years ago by sriggins

  • Owner changed from deyan to sriggins
  • Status changed from s1c_analysis_ok to s2a_design_started

comment:10 Changed 10 years ago by sriggins

  • Design_owners set to sriggins
  • Status changed from s2a_design_started to s2b_design_finished
  • Imp._owners set to sriggins

comment:11 Changed 10 years ago by sriggins

  • Status changed from s2b_design_finished to s2c_design_ok

comment:12 Changed 10 years ago by sriggins

  • Status changed from s2c_design_ok to s3a_implementation_started

comment:13 Changed 10 years ago by sriggins

  • Status changed from s3a_implementation_started to s3b_implementation_finished

branch /branches/private/sriggins/BUG_1725_ERROR_SAVING_BOOK_WITH_MEDIA

Change BinDataSource >> createFile to decode the filename before creating the file. Otherwise we end up with %20 in some places, and %2520 in others. After seeing bug reports about how 1.6 changed how toURI works in regards to endlessly encoding % to %25, I decided that decoding (via getPath) before passing to File would be the safest bet given the time before this release.

comment:14 Changed 10 years ago by sriggins

I ran /org.sophie2.main.func.media/src/test/java/org/sophie2/main/func/media/VideoFramePersistTest.java but it fails with or without my change

comment:15 Changed 10 years ago by meddle

  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Analysis_reviewers set to meddle
  • Analysis_score changed from 0 to 3.5
  • Imp._reviewers set to meddle
  • Design_score changed from 0 to 3.5
  • Design_reviewers set to meddle
  • Imp._score changed from 0 to 3.5

Merged to the trunk in [3936]. Additionally I fixed the test -> /org.sophie2.main.func.media/src/test/java/org/sophie2/main/func/media/VideoFramePersistTest.java. The problem wast that the video content in it was not created in it's frame. That is not a problem connected directly to that bug, but was a problem with the test that tested the persistence of video data.

3.5p (20m)

comment:16 Changed 10 years ago by dido

  • Status changed from s3c_implementation_ok to closed
  • Test_reviewers set to dido
  • Resolution set to fixed
Note: See TracTickets for help on using tickets.