Ticket #1754 (closed bug: fixed)

Opened 10 years ago

Last modified 10 years ago

Tweak:caret not seen in the end of the text

Reported by: diana Owned by: vlado
Priority: minor Milestone: M09_BETA1
Component: uncategorized Version: 2.0
Keywords: caret Cc: diana
Category: unknown Effort: 0.5
Importance: Ticket_group:
Estimated Number of Hours: Add Hours to Ticket:
Billable?: Total Hours:
Analysis_owners: diana Design_owners: diana
Imp._owners: diana Test_owners: deyan
Analysis_reviewers: diana, meddle Changelog:
Design_reviewers: meddle, meddle Imp._reviewers: meddle, meddle, meddle
Test_reviewers: Analysis_score: 3
Design_score: 3 Imp._score: 3
Test_score: 3

Description (last modified by deyan) (diff)

BUG_1754? The caret is not visible when the end of the text is reached.

Change History

comment:1 Changed 10 years ago by diana

  • Owner set to diana
  • Status changed from new to s1a_analysis_started

comment:2 Changed 10 years ago by diana

  • Status changed from s1a_analysis_started to s1b_analysis_finished

comment:3 Changed 10 years ago by diana

  • Status changed from s1b_analysis_finished to s1c_analysis_ok

comment:4 Changed 10 years ago by diana

  • Status changed from s1c_analysis_ok to s2a_design_started

comment:5 Changed 10 years ago by diana

  • Status changed from s2a_design_started to s2b_design_finished

comment:6 Changed 10 years ago by diana

  • Status changed from s2b_design_finished to s2c_design_ok

comment:7 Changed 10 years ago by diana

  • Status changed from s2c_design_ok to s3a_implementation_started

comment:8 Changed 10 years ago by diana

  • Status changed from s3a_implementation_started to s3b_implementation_finished

comment:9 Changed 10 years ago by deyan

  • Milestone set to M09_BETA1

ticket fix

comment:10 Changed 10 years ago by meddle

  • Cc diana added
  • Status changed from s3b_implementation_finished to s2c_design_ok
  • Design_reviewers set to meddle
  • Imp._reviewers set to meddle

Hmm there is no design and implementation in this ticket.

  • The design is your strategy to fix it, and is important because it's the documentation of the bug.
  • The implementation is the most important thing, the changeset/branch_url where the fix is placed.

At this state I can not merge/try/test/review this bug.

0p (10m)

comment:11 Changed 10 years ago by deyan

  • Description modified (diff)

comment:12 Changed 10 years ago by deyan

  • Description modified (diff)

comment:13 Changed 10 years ago by diana

  • Status changed from s2c_design_ok to s3a_implementation_started

Add a new boolean variable in the method draw in class Atom which shows if the caret is in the end of the text. If and only if the caret is in the end of the text the boolean variable end is set to true and the caret is drawn at the end of the text.

Source code can be found here : [3914]

comment:14 Changed 10 years ago by diana

  • Status changed from s3a_implementation_started to s3b_implementation_finished

comment:15 Changed 10 years ago by meddle

  • Status changed from s3b_implementation_finished to s2c_design_ok
  • Analysis_reviewers changed from diana to diana, meddle
  • Analysis_score changed from 0 to 2.5
  • Imp._reviewers changed from meddle to meddle, meddle
  • Design_score changed from 0 to 2.5
  • Design_reviewers changed from meddle to meddle, meddle
  • Imp._score changed from 0 to 2.5

Hmm the fix works fine unless you chain frames, then it breaks the chaining so at this state I can not pass this fix :(

2.5p (15m)

comment:16 Changed 10 years ago by vlado

  • Owner changed from diana to vlado
  • Status changed from s2c_design_ok to s3a_implementation_started

comment:17 Changed 10 years ago by vlado

  • Status changed from s3a_implementation_started to s3b_implementation_finished

comment:18 Changed 10 years ago by meddle

  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Design_score changed from 2.5 to 3
  • Imp._reviewers changed from meddle, meddle to meddle, meddle, meddle
  • Imp._score changed from 2.5 to 3
  • Analysis_score changed from 2.5 to 3

Merged to the trunk in [4069].

Works bad with chaining the caret is lost, but the bug was not for that so....

3p (10)

comment:19 Changed 10 years ago by deyan

testing started

comment:20 Changed 10 years ago by deyan

  • Status changed from s3c_implementation_ok to closed
  • Test_owners set to deyan
  • Resolution set to fixed
  • Test_score changed from 0 to 3

fixed

Note: See TracTickets for help on using tickets.