Ticket #1775 (closed bug: worksforme)

Opened 11 years ago

Last modified 11 years ago

add to template button causes crash

Reported by: danvisel Owned by: danvisel
Priority: major Milestone: M09_BETA1
Component: uncategorized Version: 2.0
Keywords: Cc:
Category: unknown Effort:
Importance: Ticket_group:
Estimated Number of Hours: 0 Add Hours to Ticket: 0
Billable?: yes Total Hours: 0
Analysis_owners: danvisel Design_owners: jani
Imp._owners: jani Test_owners:
Analysis_reviewers: jani Changelog:
Design_reviewers: meddle, deyan Imp._reviewers: meddle, deyan
Test_reviewers: Analysis_score: 3
Design_score: 3 Imp._score: 3
Test_score: 0

Description

  1. Make a new book.
  2. Insert a text frame.
  3. Click "Add to template" halo.

Crash on 3 - attached.

Attachments

add to template button on text frame causes crash.txt (658.9 KB) - added by danvisel 11 years ago.
add to template halo on text frame causes crash.

Change History

Changed 11 years ago by danvisel

add to template halo on text frame causes crash.

comment:1 Changed 11 years ago by danvisel

  • Owner set to danvisel
  • Status changed from new to s1a_analysis_started

comment:2 Changed 11 years ago by danvisel

  • Status changed from s1a_analysis_started to s1b_analysis_finished

comment:3 Changed 11 years ago by todor

now there's no crash, just the responsiveness of the application gets worse. i have the feeling that each time the user clicks on the "add to template" sophie's performance drastically drops.

comment:4 Changed 11 years ago by todor

i forgot to mention that this occurs only on mac

comment:5 Changed 11 years ago by jani

  • Design_owners set to jani
  • Total Hours set to 0
  • Add Hours to Ticket set to 0
  • Status changed from s1b_analysis_finished to s2a_design_started
  • Billable? set
  • Estimated Number of Hours set to 0

comment:6 Changed 11 years ago by jani

  • Status changed from s2a_design_started to s3b_implementation_finished
  • Imp._owners set to jani

A couple of issues:

  • When deriving an contant, parent().getChangeManager() should be used, instead of parent.getChangeManager().
  • A check in the frame's z-index auto property should be added for the parent (it could be null).

Also, clean up some code for the templates...

Related: #1776, #1863

Changeset: [5149]

comment:7 Changed 11 years ago by meddle

  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Analysis_reviewers set to jani
  • Analysis_score changed from 0 to 3
  • Imp._reviewers set to meddle, deyan
  • Design_score changed from 0 to 3
  • Design_reviewers set to meddle, deyan
  • Imp._score changed from 0 to 3

Ok, fixed in [5160]. There are problems with frame titlebar when templating and cyclic templates from you-to-you, but there are new bug tickets for them; Find them if you want.

comment:8 Changed 11 years ago by deyan

works in the release.

comment:9 Changed 11 years ago by deyan

windows

comment:10 Changed 11 years ago by deyan

  • Status changed from s3c_implementation_ok to closed
  • Resolution set to worksforme

fixed

Note: See TracTickets for help on using tickets.