Ticket #1787 (closed unplanned_task: obsolete)
UNPLANNED_GRADIENT_PERSISTER_R0
| Reported by: | velizar | Owned by: | velizar |
|---|---|---|---|
| Priority: | major | Milestone: | |
| Component: | BASE_PERSISTENCE | Version: | 2.0 |
| Keywords: | Cc: | velizar, dido | |
| Category: | BASE | Effort: | |
| Importance: | Ticket_group: | ||
| Estimated Number of Hours: | Add Hours to Ticket: | ||
| Billable?: | Total Hours: | ||
| Analysis_owners: | velizar | Design_owners: | velizar |
| Imp._owners: | velizar | Test_owners: | |
| Analysis_reviewers: | dido | Changelog: | |
| Design_reviewers: | meddle | Imp._reviewers: | meddle |
| Test_reviewers: | Analysis_score: | 3.5 | |
| Design_score: | 3.5 | Imp._score: | 3 |
| Test_score: | 0 |
Description
wiki page - UNPLANNED_GRADIENT_PERSISTER
Change History
comment:1 Changed 16 years ago by velizar
- Owner set to velizar
- Status changed from new to s1a_analysis_started
comment:2 Changed 16 years ago by velizar
- Status changed from s1a_analysis_started to s1b_analysis_finished
comment:3 Changed 16 years ago by dido
- Status changed from s1b_analysis_finished to new
- Analysis_score changed from 0 to 2
- Not sure is there going to be a way of load/save some gradients styles or this won't be available.
- Is there any user interface for this or we are talking about adding this functionality to the current Sophie book format.
Analysis review 2p (30m)
comment:5 Changed 16 years ago by velizar
- Status changed from s1a_analysis_started to s1b_analysis_finished
- The gradient types (linear and radial) can be written as strings in the storage on save and later the correct one to be chosen on load according to this string. Similar is the situation with CycleMethod. I will provide more details in the design section.
- We are talking about adding this to the current Sophie book functionality. it is not correct to lose ifnormation about gradient on save/load.
comment:6 Changed 16 years ago by dido
- Cc velizar, dido added
- Status changed from s1b_analysis_finished to new
- Analysis_score changed from 2 to 2.5
Excellent. Please add the comments inside the wiki page, else is fine and will pass after this.
Analysis reviewed 2.5p (30m)
comment:9 Changed 16 years ago by velizar
- Status changed from s1a_analysis_started to s1b_analysis_finished
comment:10 Changed 16 years ago by dido
- Status changed from s1b_analysis_finished to s1c_analysis_ok
- Analysis_score changed from 2.5 to 3.5
Analysis reviewed 3.5p (10m)
comment:11 Changed 16 years ago by velizar
- Status changed from s1c_analysis_ok to s2a_design_started
comment:12 Changed 16 years ago by velizar
- Status changed from s2a_design_started to s2b_design_finished
comment:14 Changed 16 years ago by meddle
- Status changed from s2b_design_finished to s2c_design_ok
- Design_score changed from 0 to 3.5
- Design_reviewers set to meddle
I think the design is OK with the following notes:
- Code related notes:
- Ident your code (It's easy Ctrl+A and then Ctrl+i)
- Write JavaDoc, not face JavaDoc (see your persister)
- Code for review (even in the design stage) is important to be according to the standarts : GoodCodeExamples
3.5p (10m)
comment:15 Changed 16 years ago by velizar
- Status changed from s2c_design_ok to s3a_implementation_started
- Imp._owners set to velizar
comment:16 Changed 16 years ago by velizar
- Status changed from s3a_implementation_started to s3b_implementation_finished
comment:17 Changed 16 years ago by deyan
If this ticket is not a bug, it should have a revision. Please rename it to UNPLANNED_GRADIENT_PERSISTER_R0
comment:18 Changed 16 years ago by dido
- Summary changed from UNPLANNED_GRADIENT_PERSISTER to UNPLANNED_GRADIENT_PERSISTER_R0
comment:19 Changed 16 years ago by meddle
- Status changed from s3b_implementation_finished to s3c_implementation_ok
- Imp._score changed from 0 to 3
- Imp._reviewers set to meddle
The implementation works, but you didn't fix the things in the design notes, so :(
And the copy-paste method of code writing is bad...
3p (40m)
comment:20 Changed 15 years ago by deyan
- Status changed from s3c_implementation_ok to closed
- Resolution set to obsolete
Batch update from file query-obsoleted.csv
Note: See
TracTickets for help on using
tickets.
