Ticket #1811 (closed bug: fixed)

Opened 16 years ago

Last modified 16 years ago

Validator of bound controls are not updated

Reported by: dido Owned by: velizar
Priority: major Milestone:
Component: BASE_GUI_LIB Version: 2.0
Keywords: Cc: dido
Category: BASE Effort:
Importance: Ticket_group:
Estimated Number of Hours: Add Hours to Ticket:
Billable?: Total Hours:
Analysis_owners: dido Design_owners: velizar
Imp._owners: velizar Test_owners: deyan
Analysis_reviewers: velizar Changelog:
Design_reviewers: meddle Imp._reviewers: meddle
Test_reviewers: Analysis_score: 4
Design_score: 4 Imp._score: 4
Test_score: 0

Description (last modified by deyan) (diff)

Steps to reproduce:

  • Run the application
  • Type incorrect data inside the bound text field box
  • The validator indicates invalid data
  • Remove the focus
  • The data inside the bound text field is set to previous default data
  • The validator still points invalid data

Probably connected with implementations of bound controls using JTextField and more specific with the listeners attached to the text field.

Change History

comment:1 Changed 16 years ago by dido

  • Owner set to dido
  • Status changed from new to s1a_analysis_started

comment:2 Changed 16 years ago by dido

  • Cc dido added
  • Status changed from s1a_analysis_started to s1b_analysis_finished
  • Analysis_owners set to dido

comment:3 Changed 16 years ago by dido

  • Description modified (diff)

comment:4 Changed 16 years ago by velizar

  • Status changed from s1b_analysis_finished to s1c_analysis_ok

comment:5 Changed 16 years ago by velizar

  • Owner changed from dido to velizar
  • Status changed from s1c_analysis_ok to s2a_design_started

comment:6 Changed 16 years ago by dido

  • Summary changed from Tweak: Validator of bound controls are not updated to Validator of bound controls are not updated

comment:7 Changed 16 years ago by dido

  • Category changed from unknown to BASE

comment:8 Changed 16 years ago by velizar

  • Status changed from s2a_design_started to s2b_design_finished

Implementations of bound controls using JTextField have a bug connected with the listeners attached to the text field. - The actual bug is that when you enter an invalid input and the text field loses focus, the error icon remains active although the last valid text is set. The reason for that is that the order of the called methods in BoundTextField.dataInputControl().focusLost() is incorrect. First the property hasFocus() is set to "false" and then the invalid text is replaced and BoundTextField uses this property to determine whether the text should be submitted to the model (computeCanSubmit() method). So in order to work the order of the methods called in focusLost shold be reversed.
Use BoundControlsDemo to test this bug - it is no longer reproducable.

Changeset: [4574]

comment:9 Changed 16 years ago by velizar

  • Design_owners set to velizar
  • Status changed from s2b_design_finished to s2c_design_ok
  • Imp._owners set to velizar

comment:10 Changed 16 years ago by velizar

  • Status changed from s2c_design_ok to s3a_implementation_started

comment:11 Changed 16 years ago by velizar

  • Status changed from s3a_implementation_started to s3b_implementation_finished

comment:12 Changed 16 years ago by meddle

  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Analysis_reviewers set to velizar
  • Analysis_score changed from 0 to 4
  • Imp._reviewers set to meddle
  • Design_score changed from 0 to 4
  • Design_reviewers set to meddle
  • Imp._score changed from 0 to 4

Merged to the trunk in [4585].

4p (10m)

comment:13 Changed 16 years ago by deyan

  • Status changed from s3c_implementation_ok to closed
  • Resolution set to fixed
  • Description modified (diff)

fixed

comment:14 Changed 16 years ago by deyan

  • Test_owners set to deyan
Note: See TracTickets for help on using tickets.