Ticket #1824 (closed tweak: obsolete)

Opened 10 years ago

Last modified 8 years ago

new-book-naming -- New books should have different names

Reported by: deyan Owned by: mira
Priority: major Milestone: M12_RELEASE
Component: uncategorized Version: 2.0
Keywords: Cc:
Category: unknown Effort:
Importance: 64 Ticket_group:
Estimated Number of Hours: 0.0 Add Hours to Ticket: 0
Billable?: yes Total Hours: 0
Analysis_owners: deyan Design_owners: diana, mira
Imp._owners: diana. mira Test_owners:
Analysis_reviewers: deyan Changelog:
Design_reviewers: meddle Imp._reviewers: pap, meddle, todor
Test_reviewers: Analysis_score: 4
Design_score: 4 Imp._score: 4
Test_score: 0

Description

When creating a new book, the name of the book is "New Book A". Only one book should have this name by default, other books shoul be "New Book B", "New Book C", .. ,"New Book AA", ...

Attachments

defBookName (6.3 KB) - added by mira 10 years ago.
patch file

Change History

comment:1 Changed 10 years ago by deyan

  • Status changed from new to s1b_analysis_finished

comment:2 Changed 10 years ago by diana

  • Design_owners set to diana
  • Status changed from s1b_analysis_finished to s2a_design_started
  • Imp._owners set to diana
  • Analysis_reviewers set to deyan

comment:3 Changed 10 years ago by diana

  • Status changed from s2a_design_started to s2b_design_finished

In AppLogic class add a new private static StringBuffer BOOK_TITLE in order to help compiting the title of every new book.
Add a new method dealTitle in order to computes new title of the book.

comment:4 Changed 10 years ago by diana

  • Status changed from s2b_design_finished to s2c_design_ok

comment:5 Changed 10 years ago by diana

  • Owner set to diana
  • Status changed from s2c_design_ok to s3a_implementation_started

comment:6 Changed 10 years ago by diana

  • Status changed from s3a_implementation_started to s3b_implementation_finished

Add a new constructor in BookItem class with a parameter - the title of the book.
source code: [4803]

comment:7 Changed 10 years ago by pap

  • Status changed from s3b_implementation_finished to s1c_analysis_ok
  • Imp._reviewers set to pap
  • Add Hours to Ticket set to 0
  • Billable? set
  • Estimated Number of Hours set to 0.0
  • Imp._score changed from 0 to 1
  • First there is not test and this feature is important enough and deserves such
  • Also I think that your solution can have only 26 different titles.
  • So you should write a test that produces enpough books to test this feature.
  • ALL_CAPITAL_LETTER_NAMES are used for constants (static final fields) only. This refers to "BOOK_TITLE".
  • The naming of variables is bad - "pren" means nothing to me and meddle finds "dealTitle" strange.

comment:8 Changed 10 years ago by vanya

  • Total Hours set to 0
  • Milestone changed from M10_BETA2 to M12_RELEASE

comment:9 Changed 10 years ago by deyan

  • Importance set to 64
  • Type changed from bug to tweak
  • Summary changed from Tweak: New books should have different names to new-book-naming -- New books should have different names

Batch update from file report_1.csv

comment:10 Changed 10 years ago by mira

  • Owner changed from diana to mira
  • Status changed from s1c_analysis_ok to s2a_design_started

comment:11 Changed 10 years ago by mira

  • Design_owners changed from diana to diana, mira
  • Status changed from s2a_design_started to s2b_design_finished
  • Imp._owners changed from diana to diana. mira

Remove the default BookInfo constant and make a getDefaultInfo() method that constructs info by the default params and uses the logic in ResourceUtil for generating appropriate title. The newly created books don`t have parents, so we can use the NONE ref for their common parent ensuring that they would have unique names.

comment:12 Changed 10 years ago by mira

  • Status changed from s2b_design_finished to s2c_design_ok

comment:13 Changed 10 years ago by mira

  • Status changed from s2c_design_ok to s3a_implementation_started

Changed 10 years ago by mira

patch file

comment:14 Changed 10 years ago by mira

  • Status changed from s3a_implementation_started to s3b_implementation_finished
  • Design_reviewers set to mira

implemented according to the design

comment:15 Changed 10 years ago by meddle

  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Analysis_score changed from 0 to 4
  • Imp._reviewers changed from pap to pap, meddle, todor
  • Design_score changed from 0 to 4
  • Design_reviewers changed from mira to meddle
  • Imp._score changed from 1 to 4

Merged to the trunk at [8307].

Amm 4p

comment:16 Changed 8 years ago by meddle

  • Status changed from s3c_implementation_ok to closed
  • Resolution set to obsolete

Closing all the tickets before M Y1

Note: See TracTickets for help on using tickets.