Ticket #1933 (closed unplanned_task)

Opened 10 years ago

Last modified 10 years ago

HOT_TEXT_REDESIGN_R2

Reported by: vlado Owned by: vlado
Priority: critical Milestone: M09_BETA1
Component: TEXT_FLOWING Version: 2.0
Keywords: feedback Cc: vlado
Category: BASE Effort:
Importance: Ticket_group:
Estimated Number of Hours: 0 Add Hours to Ticket: 0
Billable?: yes Total Hours: 0
Analysis_owners: vlado Design_owners: vlado, vlado
Imp._owners: vlado, vlado Test_owners:
Analysis_reviewers: dido Changelog:
Design_reviewers: meddle, pap, meddle Imp._reviewers: meddle, todor, meddle, todor
Test_reviewers: Analysis_score: 3
Design_score: 4 Imp._score: 3
Test_score: 0

Description

Change History

comment:1 Changed 10 years ago by vlado

  • Owner set to vlado
  • Status changed from new to s1a_analysis_started

comment:2 Changed 10 years ago by vlado

  • Status changed from s1a_analysis_started to s1b_analysis_finished

comment:3 Changed 10 years ago by dido

  • Status changed from s1b_analysis_finished to s1c_analysis_ok
  • Analysis_reviewers set to dido
  • Analysis_score changed from 0 to 3

Analysis Reviewed 3p (10m)

comment:4 Changed 10 years ago by vlado

  • Design_owners set to vlado
  • Status changed from s1c_analysis_ok to s2a_design_started

comment:5 Changed 10 years ago by vlado

  • Status changed from s2a_design_started to s2b_design_finished

comment:6 Changed 10 years ago by meddle

  • Status changed from s2b_design_finished to s1c_analysis_ok
  • Design_score changed from 0 to 1
  • Design_reviewers set to meddle, pap

Sooo we will fail it due to:

  • First of all the Styling is part of the integration with the new model... It has no design
  • Test, you have no tests, demos for styling in frameviews and I think as a whole the text is no tested enough.
  • The requirements are mandatory!!! So chaining IS part of this task, documentation (fix warnings, javadoc, document in the wiki) IS part of this task and of course the all the persisters (not only for the plain text) are part of this task.
  • In the design the persisters are not mentioned.
  • textFlow of stickyview and frameview is the same, you need to put it up in the hierarchy over the FrameView implementation... I wrote TODO over the sticky's implementation when and we talked about that...

1p (30m)

comment:7 Changed 10 years ago by todor

  • Keywords feedback added

User's feedback:

  • "Even when I saved text as an .rtf and imported it through that option, it erased all the formatting information. Text also must appear within a text box, that can have a different background color and border."

comment:8 Changed 10 years ago by vlado

  • Design_owners changed from vlado to vlado, vlado
  • Status changed from s1c_analysis_ok to s2a_design_started

comment:9 Changed 10 years ago by vlado

  • Status changed from s2a_design_started to s2b_design_finished

comment:10 Changed 10 years ago by meddle

  • Status changed from s2b_design_finished to s2c_design_ok
  • Design_score changed from 1 to 4
  • Design_reviewers changed from meddle, pap to meddle, pap, meddle

Hmm that thing with not saved history might be problematic, because after a save, the book is reloaded... so the past/future positions will be lost oftenly, I may be wrong in that.
For the implementation p[lease see todor's comment above, we will check for it.

4p (30m)

comment:11 Changed 10 years ago by meddle

  • Cc vlado added

comment:12 Changed 10 years ago by vlado

  • Status changed from s2c_design_ok to s3a_implementation_started
  • Imp._owners set to vlado

comment:13 Changed 10 years ago by vlado

  • Status changed from s3a_implementation_started to s3b_implementation_finished

History of ImmHotText is not saved and the past/future positions will be lost. That is why they are normalized during the save operation (meaning that new HotPoses are created with index which is relative to the currently saved text; and these new poses are persisted).

comment:14 Changed 10 years ago by meddle

  • Status changed from s3b_implementation_finished to s2c_design_ok
  • Imp._score changed from 0 to 2
  • Imp._reviewers set to meddle, todor

I'll fail it for now due to the color and background bug, style-change bug, not loading from the reader and the broken chaining...

2p (150m)

comment:15 Changed 10 years ago by vlado

  • Status changed from s2c_design_ok to s3a_implementation_started
  • Imp._owners changed from vlado to vlado, vlado

comment:16 Changed 10 years ago by vlado

  • Status changed from s3a_implementation_started to s3b_implementation_finished

comment:17 Changed 10 years ago by meddle

  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Imp._score changed from 2 to 3
  • Imp._reviewers changed from meddle, todor to meddle, todor, meddle, todor

So, I'll pass the task but there are some problems:

  • Code related issues:
    • You have fake JavaDoc and malformed javaDoc according to our standards.
    • You have if/else blocks without curly brackets...
    • Write equals expressions with calling the known object (null pointer danger otherwise).
  • Implementation related issues:
    • Navigating with 'End' at the last line does not position the caret after the last symbol.
    • The HUD is not synchronized with the styled selections some times.
    • The undo-redo fix...
    • The chaining problems (The null pointer I pointed you).
    • The true reader does not load books with styled text.
    • Not enough text-persisting and text-navigation tests, in my view...

3p (2h)

comment:18 Changed 10 years ago by deyan

  • Status changed from s3c_implementation_ok to closed

Batch update from file query-10.csv

Note: See TracTickets for help on using tickets.