Ticket #1974 (closed bug)

Opened 10 years ago

Last modified 10 years ago

Opened documents order should be saved

Reported by: deyan Owned by: peko
Priority: major Milestone: M12_RELEASE
Component: uncategorized Version: 2.0
Keywords: Cc:
Category: unknown Effort:
Importance: Ticket_group:
Estimated Number of Hours: 0 Add Hours to Ticket: 0
Billable?: yes Total Hours: 0
Analysis_owners: deyan Design_owners: peko
Imp._owners: peko Test_owners:
Analysis_reviewers: peko Changelog:
Design_reviewers: meddle Imp._reviewers: meddle
Test_reviewers: Analysis_score: 3
Design_score: 4 Imp._score: 4
Test_score: 0

Description (last modified by deyan) (diff)

If you have 3 opened books in this order : Book A; Book B; Book C and open and close preview of Book B, the newly focused book is Book A instead of Book B. This order should be saved for navigation with Ctrl+Tab and Ctrl+Alt+Tab

Change History

comment:1 Changed 10 years ago by deyan

  • Status changed from new to s1b_analysis_finished

comment:2 Changed 10 years ago by deyan

  • Description modified (diff)

comment:3 Changed 10 years ago by deyan

  • Description modified (diff)

comment:4 Changed 10 years ago by deyan

still present

comment:5 Changed 10 years ago by peko

  • Design_owners set to peko
  • Status changed from s1b_analysis_finished to s2a_design_started

comment:6 Changed 10 years ago by peko

  • Status changed from s2a_design_started to s2b_design_finished
  • Analysis_reviewers set to peko
  • Analysis_score changed from 0 to 3

The bug is not only for open preview. This bug is related to the fact that when current book is closed the last book is set as current. We should keep track of the last current book and when book is close the last current should become current.

comment:7 Changed 10 years ago by peko

  • Status changed from s2b_design_finished to s2c_design_ok

comment:8 Changed 10 years ago by peko

  • Owner set to peko
  • Status changed from s2c_design_ok to s3a_implementation_started
  • Imp._owners set to peko

comment:9 Changed 10 years ago by peko

  • Status changed from s3a_implementation_started to s3b_implementation_finished

comment:10 Changed 10 years ago by peko

THE PROBLEM IN SHORT:

DefaultMainWindow holds a reference to the current document. This is a value property that is set from different places. When a document is closed the following happens:

  • Clicking the close button of the title bar of the document window selects the document inside the window. This document becomes the current one. Then a CLOSE event id is used to fire a new event for closing the document. After that the document is closed and the current one eventually should be set to some other. The problem is that we do not know what to do here. What happened was to use the last document in the list of opened documents which is also the document in the last tab of the tab bar.

Solution:

  • currentDocument becomes a RW AutoProperty. A private value list property will be used to keep track of all documents from firstly selected to the current one. This way we have all the documents in order of being current. The currentDocument's compute will return the document at index (size -1) or null if the list is empty. Its doSet will remove the document provided and add it at the end of the list. In addition if document windows are minimized or all the documents are closed the list containing the order of documents access will be emptied.

comment:11 Changed 10 years ago by meddle

  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Design_score changed from 0 to 4
  • Design_reviewers set to meddle
  • Imp._score changed from 0 to 4
  • Imp._reviewers set to meddle

Merged to the trunk at [7397]. The test is good, the fix works...

4p

comment:12 Changed 10 years ago by deyan

  • Status changed from s3c_implementation_ok to closed

Batch update from file query-10.csv

Note: See TracTickets for help on using tickets.