Ticket #1990 (closed bug)

Opened 10 years ago

Last modified 10 years ago

Tweak: Error reports should be with .txt by default and e-mail should not be mandatory

Reported by: deyan Owned by: mitex
Priority: major Milestone: M12_RELEASE
Component: uncategorized Version: 2.0
Keywords: feedback Cc:
Category: unknown Effort:
Importance: Ticket_group:
Estimated Number of Hours: 0 Add Hours to Ticket: 0
Billable?: yes Total Hours: 0
Analysis_owners: deyan Design_owners: mitex
Imp._owners: mitex Test_owners:
Analysis_reviewers: mitex Changelog:
Design_reviewers: meddle Imp._reviewers: meddle, meddle
Test_reviewers: Analysis_score: 3
Design_score: 3 Imp._score: 3.5
Test_score: 0

Description (last modified by deyan) (diff)

  • E-mail should be saved somewhere and automatically shown in bug report form (when you have once entered it) OR e-mail should not be mandatory.
  • Extension of the bug reports should be .txt by default in the file browser.
  • Remove the "Attach file" since it is not clear enough and not usable until sending is possible.

Change History

comment:1 Changed 10 years ago by deyan

  • Status changed from new to s1b_analysis_finished

comment:2 Changed 10 years ago by deyan

  • Description modified (diff)

comment:3 Changed 10 years ago by deyan

  • Keywords feedback added
  • Description modified (diff)

comment:4 Changed 10 years ago by deyan

Users are confused about error reporting

  • "The error message was difficult as well. It was unclear as to what file should be attached. Otherwise, it was a standard error message."

comment:5 Changed 10 years ago by mitex

  • Design_owners set to mitex
  • Status changed from s1b_analysis_finished to s2a_design_started
  • Imp._owners set to mitex

comment:6 Changed 10 years ago by mitex

  • Status changed from s2a_design_started to s2b_design_finished

Design:

  • Remove the EmailField.submit method and change the filter in BugReportLogic.ON_EMAIL_CHANGED to listen to BoundControl.EventIds.SUBMIT.
  • In BugReportLogic.ON_SAVE_REPORT_TO_FILE: Instead of null, pass FileDialogInput.TXT_FILTER to the constructor of FileDialogInput. After closing the dialog, call FileDialogInput.appendFileExtension.
  • Remove all code related to file attachments. Fix the number of rows in the report data field so there's no empty space in the dialog.

Implementation:
The bug is fixed, but it depends on FileEntryManager.
[6818]

comment:7 Changed 10 years ago by mitex

  • Status changed from s2b_design_finished to s2c_design_ok

comment:8 Changed 10 years ago by mitex

  • Owner set to mitex
  • Status changed from s2c_design_ok to s3a_implementation_started

comment:9 Changed 10 years ago by mitex

Implementation:
[6818], [6824]
FileEntryManager still needs to be fixed.

comment:10 Changed 10 years ago by mitex

New implementation:
[7178], [7185]

comment:11 Changed 10 years ago by mitex

  • Status changed from s3a_implementation_started to s3b_implementation_finished

The bug is fixed a week ago, the test cannot run, but there's no time for more work on this bug.

comment:12 Changed 10 years ago by mitex

The test worked in the previous branch, the problem is not related with the bug.

comment:13 Changed 10 years ago by meddle

  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Analysis_reviewers set to mitex
  • Analysis_score changed from 0 to 3
  • Imp._reviewers set to meddle
  • Design_score changed from 0 to 3
  • Design_reviewers set to meddle
  • Imp._score changed from 0 to 3

Merged into the trunk at [7216]. I told you how to fix your test, but you didn't do it... I fixed it...

3p

comment:14 Changed 10 years ago by mitex

The implementation is merged into the trunk, but for some reason it is overwritten with the old one in [7293], so it has to be merged again.

comment:15 Changed 10 years ago by deyan

  • Status changed from s3c_implementation_ok to s1c_analysis_ok

Not fixed, e-mail is still not saved and is mandatory. Save the e-mail somewhere or make the e-mail not mandatory.

comment:16 Changed 10 years ago by mitex

  • Status changed from s1c_analysis_ok to s2a_design_started

comment:17 Changed 10 years ago by mitex

  • Status changed from s2a_design_started to s3b_implementation_finished

Design:
Use getWritableFileEntry instead of getReadableFileEntry in ConfigPersistUtil.
Call ConfigPersistUtil.saveConfiguration(this) on each call to Configuration.setValue.
Delete the directory src/main/resources/distrib/conf/ in org.sophie2.main.func.help.

Implementation:
svn://sophie2.org/sophie2/branches/private/mitex/bugfix-1990-4 [7595]

comment:18 Changed 10 years ago by meddle

  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Imp._score changed from 3 to 3.5
  • Imp._reviewers changed from meddle to meddle, meddle

I think the email is saved now... and it's not mandatory...

Put in trunk at [7614].

comment:19 Changed 10 years ago by deyan

  • Status changed from s3c_implementation_ok to closed

Batch update from file query-10.csv

Note: See TracTickets for help on using tickets.