Comment frames do not show what was commented

[deyan]

Create a book, insert a comment frame, open preview mode and add some comments. Save and reload the book, the comments in the frame are not displayed (but they should)

[kyli]

The problem is that every resource frame in a book has relative refs to its main resource. So, when a book is copied (on opening preview), the main resource is also copied.. and comment stream changes are not affecting the original book. There are other problems closely related to this one - the reader does not have the ability to persist anything, so changes to fileSystem books could not be persisted. The things are not so with the server - then you open a server book with the reader, it synchronizes its resources, so all changes are sent to the server. But this is generally not desired, since changes caused from links are also sent to the server. So, the bugfix consists of the following steps:

• Make AppViewUtil.openBook() open a copy of the real book if the edition is SDI one. This is the method called from the reader to open a new book.. So, the resulting behaviour will be the same as with the preview mode in author edition - changes made to the copy do not affect the original book.
• In the SDI case of openBook and in the logic, opening book preview, fire event which signifies that the book is being copied. This event will be handled by the CommentLogic, so that it will know about the source bookView and the bookView of the copied book. It will find all CommentFrameView`s in them and set the relative refs to absolute ones. This way, the comment streams wll still be copied, but the frames will work with the original streams. In the server case, the original comment stream will continue synchronizing with the server and only changes to it will be sent. In the author (preview mode) case, the copied frames will work with the original streams, so changes will be visible after preview closing.

[kyli]

After a discussion, we decided not to persist books originating from file system in the reader. An appropriate message is popped up.

[kyli]

Forgot to link the branch.

[meddle]

Notes:

• Problems when merging, bad branch...
• I think that kind of fix needs tests!
• When you open a saved to file book in the Author that contains comment frames and you click preview, you see the message like in the reader, but then you can modify the comment frame and the modifications go to the real book, then when you click to save the real book on the 'save' item from the file menu, you've got an Assertation Error...

So I'll fail this fix, but your code will go to the trunk, because it adds new functionality, I'll delete your bad branch. You can try to fix the Assertation Error branching the trunk in a clean branch again, your code will be in the trunk...

Put in trunk at [7486].

2.5p (40m)

[kyli]

[7592].

[meddle]

And now... fixed in [7611]...

I'm sorry I had to lose your time but at the end the fix is working perfectly!

4.5p (20m)

[deyan]

Batch update from file query-10.csv