Ticket #2034 (closed bug: obsolete)

Opened 10 years ago

Last modified 8 years ago

resources-delete-palette - Delete resources from resources palette

Reported by: vanya Owned by: diana
Priority: critical Milestone: M12_RELEASE
Component: uncategorized Version: 2.0
Keywords: Cc: todor
Category: unknown Effort:
Importance: 97 Ticket_group:
Estimated Number of Hours: 0 Add Hours to Ticket: 0
Billable?: yes Total Hours: 0
Analysis_owners: vanya Design_owners: diana
Imp._owners: diana Test_owners:
Analysis_reviewers: meddle Changelog:
Design_reviewers: meddle Imp._reviewers: meddle, todor
Test_reviewers: Analysis_score: 4
Design_score: 3 Imp._score: 3.5
Test_score: 0

Description (last modified by diana) (diff)

There is no way to delete a resource even if you've got no intention to use it.

  • Provide a delete button next to "Import" and "Export".
  • The user must be able to delete a resource from resource palette only by selecting it and hitting delete.
  • If the resource is currently used by another existing resource, it should not be deleted - a message should be shown to inform the user that the resource is used and cannot be deleted.
  • There must be a confirmation dialog similar to the one used when deleting frames.
  • If page or frame is deleted and there were links associated with this resource when triggers are executed nothing must happen (especially not throwing exceptions).
  • (optional) Deleting of resources must be udoable.

Change History

comment:1 Changed 10 years ago by vanya

  • Status changed from new to s1b_analysis_finished

comment:2 Changed 10 years ago by vanya

  • Description modified (diff)
  • Summary changed from [natives][linux32] TLID:1177 and TLID:821 Resources cannot be deleted through Resource palette to [natives] TLID:1177 and TLID:821 Resources cannot be deleted through Resource palette

comment:3 Changed 10 years ago by vanya

  • Analysis_owners set to vanya

comment:4 Changed 10 years ago by deyan

  • Priority changed from major to critical
  • Description modified (diff)
  • Summary changed from [natives] TLID:1177 and TLID:821 Resources cannot be deleted through Resource palette to TLID:1177 and TLID:821 Resources cannot be deleted through Resource palette

comment:5 Changed 10 years ago by deyan

  • Importance set to 97
  • Summary changed from TLID:1177 and TLID:821 Resources cannot be deleted through Resource palette to resources-delete-palette – Delete resources from resources palette

Batch update from file report_1.csv

comment:6 Changed 10 years ago by deyan

  • Summary changed from resources-delete-palette – Delete resources from resources palette to resources-delete-palette – Delete resources from resources palette

Batch update from file 0911261.csv

comment:7 Changed 10 years ago by todor

  • Summary changed from resources-delete-palette – Delete resources from resources palette to resources-delete-palette - Delete resources from resources palette

comment:8 Changed 10 years ago by meddle

  • Status changed from s1b_analysis_finished to new
  • Analysis_reviewers set to meddle

I'm failing the analysis, all the types of the resources have different problems while deleting for example content resources with more than one frames, pages and frames with links to them and etc...

comment:9 Changed 10 years ago by meddle

  • Cc todor added

comment:10 Changed 10 years ago by todor

  • Status changed from new to s1b_analysis_finished
  • Description modified (diff)

comment:11 Changed 10 years ago by diana

  • Design_owners set to diana
  • Imp._owners set to diana

comment:12 Changed 10 years ago by diana

  • Description modified (diff)

comment:13 Changed 10 years ago by diana

  • Status changed from s1b_analysis_finished to s2a_design_started

In order to provide the wanted result the following changes were made:

  • In BookView.EventIds add ELEMENT_DELETED - used when a page/frame or group has been deleted.
  • Change FrameHalosLogic:ON_FRAME_REMOVE_CONFIRMED to handle the event with eventID = BookView.EventIds.ELEMENT_DELETED
  • In GroupHalosLogic add a new value: ON_GROUP_DELETED - handles the deleting of a selected group from the resource palette.
  • In org.sophie2.main.func.resources.logic package add a new enum ResourceDeleteLogic. In handles the deleting of a selected resource from the resource palette. The logic is as follows:
    • check if the selected resource is main resource-if so and if the resource is not used it is removed.
    • if the resource is a page or frame template and is not used - it is removed.
    • if the resource is frame a new event is fired and handled by the other logics in Sophie2.
  • In ResourceDetailsPalette add a new class DeleteResourceButton - the delete button of the palette.

comment:14 Changed 10 years ago by diana

source code: [8491] [8488] [8489] [8490]

comment:15 Changed 10 years ago by diana

source code: [8492]

comment:16 Changed 10 years ago by diana

  • Status changed from s2a_design_started to s2b_design_finished

source code: [8498] [8498]

comment:17 Changed 10 years ago by diana

source code: [8500]

comment:18 Changed 10 years ago by meddle

  • Status changed from s2b_design_finished to s2c_design_ok
  • Design_score changed from 0 to 3
  • Design_reviewers set to meddle
  • Analysis_score changed from 0 to 4

The design as an idea is fine:

  • But you was lazy to write that you filter the events by their parameters, so I was confused a bit about the thing with the FrameHalosLogic:ON_FRAME_REMOVE_CONFIRMED handler... I saw that in the code and Pap told me...
  • You didn't mention the changes in some special frames like the Browser Frame for example.
  • You should write in the design of such task what icons you will use for the buttons...

3p

comment:19 Changed 10 years ago by diana

  • Owner set to diana
  • Status changed from s2c_design_ok to s3a_implementation_started

comment:20 Changed 10 years ago by diana

  • Status changed from s3a_implementation_started to s3b_implementation_finished

comment:21 Changed 10 years ago by meddle

  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Imp._score changed from 0 to 3.5
  • Imp._reviewers set to meddle, todor

Merged to the trunk at [8510].

  • Spacing, identing... :)
  • With PDF resources deleting there was exception thrown (fixed)
  • Strange comparing of resource refs.
  • And code repeating...

3.5p

comment:22 Changed 8 years ago by meddle

  • Status changed from s3c_implementation_ok to closed
  • Resolution set to obsolete

Closing all the tickets before M Y1

Note: See TracTickets for help on using tickets.