Ticket #2067 (closed bug: fixed)

Opened 10 years ago

Last modified 10 years ago

Trying to overwrite a book throws an exception

Reported by: deyan Owned by:
Priority: major Milestone: M12_RELEASE
Component: uncategorized Version: 2.0
Keywords: Cc:
Category: unknown Effort:
Importance: Ticket_group:
Estimated Number of Hours: 0 Add Hours to Ticket: 0
Billable?: yes Total Hours: 0
Analysis_owners: deyan Design_owners: mitex
Imp._owners: mitex Test_owners:
Analysis_reviewers: mitext Changelog:
Design_reviewers: meddle Imp._reviewers: meddle
Test_reviewers: Analysis_score: 2.5
Design_score: 2.5 Imp._score: 2.5
Test_score: 0

Description

When you try to overwrite a book an exception is thrown and the book is probably not overwritten.

Attachments

2067.txt (6.3 KB) - added by deyan 10 years ago.

Change History

Changed 10 years ago by deyan

comment:1 Changed 10 years ago by deyan

  • Status changed from new to s1b_analysis_finished

comment:2 Changed 10 years ago by deyan

  • Milestone set to M12_RELEASE

comment:3 Changed 10 years ago by mitex

  • Design_owners set to mitex
  • Status changed from s1b_analysis_finished to s2a_design_started
  • Imp._owners set to mitex

Design:
In FileMenuLogic.saveBookToFile check to see if the new reference is different than the previous one. If not, call the logic for "Save" (just call DelegatingFileAccess.save), instead of "Save As".

comment:4 Changed 10 years ago by mitex

  • Status changed from s2a_design_started to s3b_implementation_finished

comment:5 Changed 10 years ago by meddle

  • Status changed from s3b_implementation_finished to s2c_design_ok
  • Analysis_reviewers set to mitext
  • Analysis_score changed from 0 to 2.5
  • Imp._reviewers set to meddle
  • Design_score changed from 0 to 2.5
  • Design_reviewers set to meddle
  • Imp._score changed from 0 to 2.5

The fix don't work in the case when you create book, save it, create another book without exiting sophie and save it in the file of the first one, then the exception attached arises.
So I will fail the bug, but your code fixes the test and the other case, when you exit sophie, so I'll integrate it and delete your branch, you can try to fix the mentioned above case by branching the trunk and using your code in it...

Merged to the trunk at [7482].

2.5p (25m)

comment:6 Changed 10 years ago by todor

  • Status changed from s2c_design_ok to closed
  • Resolution set to fixed
Note: See TracTickets for help on using tickets.