Ticket #2086 (closed bug)

Opened 10 years ago

Last modified 10 years ago

Grouped frames cannot be saved

Reported by: deyan Owned by:
Priority: major Milestone: M12_RELEASE
Component: uncategorized Version: 2.0
Keywords: Cc:
Category: unknown Effort:
Importance: Ticket_group:
Estimated Number of Hours: 0 Add Hours to Ticket: 0
Billable?: yes Total Hours: 0
Analysis_owners: deyan Design_owners: kyli
Imp._owners: kyli Test_owners:
Analysis_reviewers: kyli Changelog:
Design_reviewers: meddle Imp._reviewers: meddle
Test_reviewers: Analysis_score: 4
Design_score: 4 Imp._score: 4
Test_score: 0

Description

Create a group of two frames, save the book, restart Sophie and try to open the book, an exception is thrown, the book should be loadable.

Attachments

2086.txt (7.2 KB) - added by deyan 10 years ago.
2086.patch (747 bytes) - added by kyli 10 years ago.

Change History

Changed 10 years ago by deyan

comment:1 Changed 10 years ago by deyan

  • Status changed from new to s1b_analysis_finished

comment:2 Changed 10 years ago by kyli

  • Status changed from s1b_analysis_finished to s2a_design_started

comment:3 Changed 10 years ago by kyli

  • Design_owners set to kyli
  • Status changed from s2a_design_started to s3b_implementation_finished
  • Imp._owners set to kyli

The channel persister misses a check for not persisted size, which throws NullPointerException on load. The size would not be persisted in the groups' case, where a group location is still never set. So, nothing is saved and exception appears. The fix is to add a check for this case and if present, a default value of 0 will be assigned for the size. So, the persister will reproduce a default empty channel. The bugfix consists of 3 lines and I do not think it is reasonable to create new branch, check it out, import in eclipse, then commit, eventually merge, and so on. A patch is attached.

Changed 10 years ago by kyli

comment:4 Changed 10 years ago by meddle

  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Analysis_reviewers set to kyli
  • Analysis_score changed from 0 to 4
  • Imp._reviewers set to meddle
  • Design_score changed from 0 to 4
  • Design_reviewers set to meddle
  • Imp._score changed from 0 to 4

Put in the trunk at [7484]... You are right, it was easy 'merge' :)

4p (5m)

comment:5 Changed 10 years ago by deyan

  • Status changed from s3c_implementation_ok to closed

Batch update from file query-10.csv

Note: See TracTickets for help on using tickets.