Ticket #2091 (closed bug)

Opened 10 years ago

Last modified 10 years ago

Links do not work with grouped groups.

Reported by: kyli Owned by:
Priority: major Milestone: M12_RELEASE
Component: uncategorized Version: 2.0
Keywords: Cc:
Category: unknown Effort:
Importance: Ticket_group:
Estimated Number of Hours: 0 Add Hours to Ticket: 0
Billable?: yes Total Hours: 0
Analysis_owners: kyli Design_owners: kyli
Imp._owners: kyli Test_owners:
Analysis_reviewers: kyli Changelog:
Design_reviewers: meddle Imp._reviewers: meddle
Test_reviewers: Analysis_score: 3.5
Design_score: 3.5 Imp._score: 3.5
Test_score: 0

Description

  1. Create a new book
  2. Insert text frame A, text frame B, text frame C.
  3. Add link "MOUSE_CLICKED : Toggle frame : Frame C" on frame A.
  4. Group frame B and frame C (resulting in group A).
  5. Group frame A and group A.
  6. Open book preview, click on frame A. Frame C should hide.

Change History

comment:1 Changed 10 years ago by kyli

  • Milestone set to M12_RELEASE

comment:2 Changed 10 years ago by kyli

  • Status changed from new to s1b_analysis_finished

comment:3 Changed 10 years ago by kyli

  • Status changed from s1b_analysis_finished to s2a_design_started

Design

There are 2 problems related to this :

  • Redirect resources hold a reference, relative to the parent book, not relative to the current location. This means that moving a redirect will brake the resource. Also, book-related refs would not work with server resource accesses, since the master top access there is not a book. So, the ModelResourceChanger.moveResource() method must create a redirect with the relative from "source" to "dest".
  • Moving a resource does not take in mind child resources, so if you move a group with a frame in another group, the moved frame will not have corresponding redirect. The MasterTopAccess.open() method should be smart enough to check all the parents of the specified resource before opening it. So, for every resource it must first open access to its parent. If we suppose the method is working, then we will have a correct ref to the parent. So, the only thing to do is to check the concrete target for redirect.

Implementation

[7206].

comment:4 Changed 10 years ago by kyli

  • Design_owners set to kyli
  • Status changed from s2a_design_started to s3b_implementation_finished
  • Imp._owners set to kyli

comment:5 Changed 10 years ago by meddle

  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Analysis_reviewers set to kyli
  • Analysis_score changed from 0 to 3.5
  • Imp._reviewers set to meddle
  • Design_score changed from 0 to 3.5
  • Design_reviewers set to meddle
  • Imp._score changed from 0 to 3.5

Merged to the trunk at [7212], I write the 'equals' calls like in the GoodCodeExamples and asserts with messages as 'See the JavaDoc' are not good ones...

3.5p (55m)

comment:6 Changed 10 years ago by deyan

  • Status changed from s3c_implementation_ok to closed

Batch update from file query-10.csv

Note: See TracTickets for help on using tickets.