Ticket #2093 (closed bug: obsolete)

Opened 10 years ago

Last modified 8 years ago

The videos in the embedded books can not be played.

Reported by: todor Owned by:
Priority: major Milestone: M12_RELEASE
Component: uncategorized Version: 2.0
Keywords: video Cc:
Category: unknown Effort:
Importance: 60 Ticket_group:
Estimated Number of Hours: 0 Add Hours to Ticket: 0
Billable?: yes Total Hours: 0
Analysis_owners: todor, vanya Design_owners: stefan
Imp._owners: stefan Test_owners:
Analysis_reviewers: stefan Changelog:
Design_reviewers: meddle Imp._reviewers: meddle, deyan
Test_reviewers: Analysis_score: 3
Design_score: 4 Imp._score: 4
Test_score: 0

Description (last modified by vanya) (diff)

  1. Create a new book.
  2. Add a video frame.
  3. Save and close the book.
  4. Create a new book.
  5. Embed the first book in this book.
  6. Try to play the video in the embedded book.
  7. Open the Preview of the current book.
  8. Try to play the video in the preview of the book.

The video from the embedded book can not be played neither in edit nor in preview mod of the second book. The controls change adequately on clicking - play icon turns into pause icon on clicking, pause icon turn into play icon after clicking on stop icon.

Attachments

2093.patch (1.5 KB) - added by stefan 10 years ago.

Change History

comment:1 Changed 10 years ago by todor

  • Status changed from new to s1b_analysis_finished

comment:2 Changed 10 years ago by vanya

  • Keywords video added
  • Description modified (diff)
  • Analysis_owners changed from todor to todor, vanya

comment:3 Changed 10 years ago by deyan

  • Importance set to 45

Batch update from file 0911261.csv

comment:4 Changed 10 years ago by todor

  • Importance changed from 45 to 60

comment:5 Changed 10 years ago by stefan

  • Status changed from s1b_analysis_finished to s2a_design_started

Changed 10 years ago by stefan

comment:6 Changed 10 years ago by stefan

  • Status changed from s2a_design_started to s3b_implementation_finished

Reason why embedded books couldn't play any media was that its BookView (which is represented as property in the EmbeddedBookFrameView) didn't change its time. In order to make that work, we had to override the MediaComposite methods of EmbeddedBookFrameView, in order to update the time of the actual embedded book, not the frame it is contained in, which was the case till now:

  • setTime:
    @Override
    public void setTime(TimePos time) {
    	embeddedView().get().setTime(time);
    }
    
  • getAudioChunks
    @Override
    public void getAudioChunks(List<AudioChunk> res, TimePos time) {
    	embeddedView().get().getAudioChunks(res, time);
    }
    

comment:7 Changed 10 years ago by stefan

  • Design_owners set to stefan
  • Imp._owners set to stefan

comment:8 Changed 10 years ago by meddle

  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Analysis_reviewers set to stefan
  • Analysis_score changed from 0 to 3
  • Imp._reviewers set to meddle, deyan
  • Design_score changed from 0 to 4
  • Design_reviewers set to meddle
  • Imp._score changed from 0 to 4

Merged to the trunk at [8637].

You are the analysis reviewer, so add score...

comment:9 Changed 8 years ago by meddle

  • Status changed from s3c_implementation_ok to closed
  • Resolution set to obsolete

Closing all the tickets before M Y1

Note: See TracTickets for help on using tickets.