Ticket #2095 (closed unplanned_task)

Opened 10 years ago

Last modified 10 years ago

GROUP_TEMPLATES_R4

Reported by: deyan Owned by: jani
Priority: major Milestone: M12_RELEASE
Component: uncategorized Version: 2.0
Keywords: Cc:
Category: unknown Effort:
Importance: Ticket_group:
Estimated Number of Hours: 0 Add Hours to Ticket: 0
Billable?: yes Total Hours: 0
Analysis_owners: deyan Design_owners: jani, jani
Imp._owners: jani Test_owners:
Analysis_reviewers: dido Changelog:
Design_reviewers: meddle, meddle Imp._reviewers: meddle, todor
Test_reviewers: Analysis_score: 4
Design_score: 3.5 Imp._score: 4
Test_score: 0

Change History

comment:1 Changed 10 years ago by deyan

  • Owner set to deyan
  • Status changed from new to s1a_analysis_started
  • Description modified (diff)

comment:2 Changed 10 years ago by deyan

  • Description modified (diff)

comment:3 Changed 10 years ago by deyan

  • Status changed from s1a_analysis_started to s1b_analysis_finished

comment:4 Changed 10 years ago by dido

  • Status changed from s1b_analysis_finished to s1c_analysis_ok
  • Analysis_reviewers set to dido
  • Analysis_owners set to deyan
  • Analysis_score changed from 0 to 4

Analysis Reviewed 4p (15m)

comment:5 Changed 10 years ago by jani

  • Design_owners set to jani
  • Owner changed from deyan to jani
  • Status changed from s1c_analysis_ok to s2a_design_started

comment:6 Changed 10 years ago by jani

  • Status changed from s2a_design_started to s2b_design_finished

comment:7 Changed 10 years ago by meddle

  • Status changed from s2b_design_finished to s1c_analysis_ok
  • Design_score changed from 0 to 2
  • Design_reviewers set to meddle

I have some notes...

  • First in the requirements you have : 'Add frame list under the page options when adding to template ', which is not mentioned in the design... Is it not implementable at this point?
  • Second the location template is already taken in mind, you should update with the current trunk.
  • You must be very careful when altering the DND logic, you must not break the current DND of images and text from the ResourcePalette to the PageWorkArea... I think you need DND tests for this part
  • Write Constant.equals(expression) instead of for example reader.getRaw(this).equals(ResourceR4.KIND)
  • Don't write fake JavaDoc.. for example the description of the class -> TemplatedResourceRefKey
  • Please fix the problem with the stack overflow when applying a template to itself... may be it will be automatically fixed with the copied template...

So at this point I can not pass this design, but it's important for the release to have more 'smart' templates, so I suggest we integrate code which don't break anything and after the release you can work over this version of the trunk to complete this whole task. If you have any ideas write to me or pap...

2p (35m)

comment:8 Changed 10 years ago by meddle

  • Status changed from s1c_analysis_ok to new

Moving it to new by request from Deyan...

comment:9 Changed 10 years ago by deyan

  • Owner changed from jani to deyan
  • Status changed from new to s1a_analysis_started

comment:10 Changed 10 years ago by deyan

  • Status changed from s1a_analysis_started to s1b_analysis_finished

comment:11 Changed 10 years ago by todor

  • Status changed from s1b_analysis_finished to s1c_analysis_ok

there are no changes except that one requirement is optional now.

comment:12 Changed 10 years ago by jani

  • Design_owners changed from jani to jani, jani
  • Owner changed from deyan to jani
  • Status changed from s1c_analysis_ok to s2a_design_started

comment:13 Changed 10 years ago by jani

  • Status changed from s2a_design_started to s2b_design_finished

comment:14 Changed 10 years ago by meddle

  • Status changed from s2b_design_finished to s2c_design_ok
  • Design_score changed from 2 to 3.5
  • Design_reviewers changed from meddle to meddle, meddle

After the discussions with Jani and Deyan passing it to de-ok.

comment:15 Changed 10 years ago by jani

  • Status changed from s2c_design_ok to s3a_implementation_started
  • Imp._owners set to jani

comment:16 Changed 10 years ago by jani

  • Status changed from s3a_implementation_started to s3b_implementation_finished

comment:17 Changed 10 years ago by meddle

  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Imp._score changed from 0 to 4
  • Imp._reviewers set to meddle, todor

So we merged it, tested it and there are no visible problems, The book template have the page template problems though...

4p (2h)

comment:18 Changed 10 years ago by deyan

  • Status changed from s3c_implementation_ok to closed

Batch update from file query-10.csv

Note: See TracTickets for help on using tickets.