Ticket #2124 (closed unplanned_task)

Opened 15 years ago

Last modified 15 years ago

RESOURCES_EXPORT_IMPORT_R0

Reported by: milen Owned by: meddle
Priority: major Milestone:
Component: uncategorized Version: 2.0
Keywords: Cc:
Category: unknown Effort:
Importance: Ticket_group:
Estimated Number of Hours: 0 Add Hours to Ticket: 0
Billable?: yes Total Hours: 0
Analysis_owners: milen, deyan, meddle Design_owners: pap, meddle
Imp._owners: meddle, pap Test_owners:
Analysis_reviewers: Changelog:
Design_reviewers: kyli Imp._reviewers: deyan, kyli
Test_reviewers: Analysis_score: 3.5
Design_score: 4 Imp._score: 0
Test_score: 0

Description (last modified by milen) (diff)

wiki page: RESOURCES_EXPORT_IMPORT_R0

Change History

comment:2 Changed 15 years ago by milen

  • Description modified (diff)

comment:3 Changed 15 years ago by milen

  • Owner set to milen
  • Status changed from new to s1a_analysis_started

comment:4 Changed 15 years ago by milen

  • Status changed from s1a_analysis_started to s1b_analysis_finished

comment:5 Changed 15 years ago by meddle

  • Analysis_owners changed from milen to milen, deyan, meddle

comment:6 Changed 15 years ago by todor

  • Status changed from s1b_analysis_finished to s1c_analysis_ok
  • Analysis_score changed from 0 to 3.5

good design, but some of the requirements are not cleared, whether they should be done the way they are considered after the discussions with milo or not, also keeping in mind the scope of this task it could take more than a week.

comment:7 Changed 15 years ago by meddle

  • Design_owners set to pap, meddle
  • Owner changed from milen to meddle
  • Status changed from s1c_analysis_ok to s2a_design_started

comment:8 Changed 15 years ago by meddle

  • Status changed from s2a_design_started to s2b_design_finished

comment:9 Changed 15 years ago by kyli

  • Status changed from s2b_design_finished to s2c_design_ok
  • Design_score changed from 0 to 4
  • Design_reviewers set to kyli

I see that the implementation is nearly finished, so the design should be OK :) Just to share my opinion:

  • I feared that this implementation will be much bloated and tons of code will be needed every time a new resource is added. When I saw your branch, it turned out that I was totaly wrong. I hope that I'm wrong..
  • Some details about the providers didn't get clear to me from the design (for example, why should main.func.text depend on main.func.resources, will ON_IMPORT_RESOURCE handle only content resources, or you will be able to insert a frame directly in a book). However, your code does not miss JavaDoc, so it is much better to write the details there.. It is easier to look at the code than to search the wiki.
  • ColdTextResource could be confusing for a new guy looking at the resource hierrarchy. I find it cool, anyway :)
  • Please, make sure dido provides you the icons for the palette. We cannot afford wasting time for a new task in order just to put several icons in the trunk.

4p, 90m

comment:10 Changed 15 years ago by meddle

  • Status changed from s2c_design_ok to s3a_implementation_started
  • Imp._owners set to meddle, pap

comment:11 Changed 15 years ago by meddle

  • Status changed from s3a_implementation_started to s3b_implementation_finished

comment:12 Changed 15 years ago by kyli

  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Imp._reviewers set to deyan, kyli

The implementation seems OK, there are no problems found, it has the icons provided and running tests. 4p.

Merged to the trunk in [7871].

comment:13 Changed 15 years ago by deyan

  • Status changed from s3c_implementation_ok to closed

Batch update from file query-10.csv

Note: See TracTickets for help on using tickets.