Ticket #2128 (closed unplanned_task)

Opened 10 years ago

Last modified 10 years ago


Reported by: deyan Owned by: diana
Priority: major Milestone: M12_RELEASE
Component: uncategorized Version: 2.0
Keywords: Cc:
Category: unknown Effort:
Importance: Ticket_group:
Estimated Number of Hours: 0 Add Hours to Ticket: 0
Billable?: yes Total Hours: 0
Analysis_owners: deyan, diana Design_owners: diana
Imp._owners: Test_owners:
Analysis_reviewers: dido Changelog:
Design_reviewers: meddle Imp._reviewers: deyan, meddle, todor
Test_reviewers: Analysis_score: 3
Design_score: 3 Imp._score: 3.5
Test_score: 0


Change History

comment:1 Changed 10 years ago by deyan

  • Owner set to deyan
  • Status changed from new to s1a_analysis_started

comment:2 Changed 10 years ago by diana

  • Status changed from s1a_analysis_started to s1b_analysis_finished

comment:3 Changed 10 years ago by dido

  • Status changed from s1b_analysis_finished to s1c_analysis_ok
  • Analysis_reviewers set to dido
  • Analysis_score changed from 0 to 3
  • Please close the bracket inside the following sentence Font (if present, else a default font
  • Also if the user don't have the desire font that is used inside the rtf file, the application should inform him somehow. Warning message should do the job.

Analysis Reviewed 3p (10m)

comment:4 Changed 10 years ago by diana

  • Owner changed from deyan to diana
  • Status changed from s1c_analysis_ok to s2a_design_started

comment:5 Changed 10 years ago by diana

  • Status changed from s2a_design_started to s2b_design_finished

comment:6 Changed 10 years ago by meddle

  • Design_owners set to diana
  • Design_score changed from 0 to 3
  • Design_reviewers set to meddle
  • Status changed from s2b_design_finished to s2c_design_ok
  • Analysis_owners changed from deyan, didi to deyan, diana

I have some notes of course:

  • The test brings up the whole Sophie, your logic is mainly in ApplyRtfStylesUtility.java so you had to write small test for it and not that monster-test, you copy-pasted the bring up from some demo, for example this : System.setProperty("bundlesConfigFile", "http://"); is needed only for the demos to run :) I think It's comment is mine...
  • You should write 'equals' methods with the known object as calling for example "some string".equals(variable), and not variable.equals("some string"), because at that point the variable may be null and you get NullPointerException.
  • switch is better then 1000 if-else statements, better for reading at least...
  • I really don't like the use of ctrl+shift+F if you don't hyphenate your code correctly after that.
  • The design for this tasks is more than enough, I'm interested in exporting in rtf for the text... Is it gonna be easy with something similar to that util?

And write your identifier in the fields, it's 'diana', not 'didi', 'didi' will break the python script...

3p (25m)

comment:7 Changed 10 years ago by diana

  • Status changed from s2c_design_ok to s3a_implementation_started

comment:8 Changed 10 years ago by diana

  • Status changed from s3a_implementation_started to s3b_implementation_finished

comment:9 Changed 10 years ago by meddle

  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Imp._score changed from 0 to 3.5
  • Imp._reviewers set to deyan, meddle, todor

Merged to the trunk at [7872].


comment:10 Changed 10 years ago by deyan

  • Status changed from s3c_implementation_ok to closed

Batch update from file query-10.csv

Note: See TracTickets for help on using tickets.