Ticket #2134 (closed unplanned_task)

Opened 10 years ago

Last modified 10 years ago

PAGE_STRUCTURE_PALETTE_R0

Reported by: milen Owned by: meddle
Priority: major Milestone:
Component: uncategorized Version: 2.0
Keywords: Cc:
Category: unknown Effort:
Importance: Ticket_group:
Estimated Number of Hours: 0 Add Hours to Ticket: 0
Billable?: yes Total Hours: 0
Analysis_owners: milen Design_owners: meddle
Imp._owners: meddle Test_owners:
Analysis_reviewers: todor Changelog:
Design_reviewers: pap Imp._reviewers: pap, todor
Test_reviewers: Analysis_score: 3.5
Design_score: 3.5 Imp._score: 4
Test_score: 0

Description (last modified by milen) (diff)

Change History

comment:1 Changed 10 years ago by milen

  • Owner set to milen
  • Status changed from new to s1a_analysis_started
  • Description modified (diff)

comment:2 Changed 10 years ago by milen

  • Status changed from s1a_analysis_started to s1b_analysis_finished

comment:3 Changed 10 years ago by todor

  • Status changed from s1b_analysis_finished to s1c_analysis_ok
  • Analysis_reviewers set to todor
  • Analysis_score changed from 0 to 3.5

good analysis, however there are some not very clear explanations.

comment:4 Changed 10 years ago by meddle

  • Design_owners set to meddle
  • Owner changed from milen to meddle
  • Status changed from s1c_analysis_ok to s2a_design_started

comment:5 Changed 10 years ago by meddle

  • Status changed from s2a_design_started to s2b_design_finished

Finishing the design....

comment:6 Changed 10 years ago by pap

  • Status changed from s2b_design_finished to s2c_design_ok
  • Design_score changed from 0 to 3.5
  • Design_reviewers set to pap
  • The name CompoundPalette is a bit strange to me as palettes are compound by their nature :) I accept this as an intermediate solution but still think this header/footer/main-part is common to all palettes.
  • I think that the clicked/doubleClicked/keyPressed methods of the InteractibleItem should not be abstract but should fire EventR3s( more precisely InputEventR3s). This way we have a better MVC and will be more consistent.
  • Maybe InteractibleItem should be InteractiblePaletteItem ?? or you mean it is somethind more general and can be used in some other places? Which will these places be?
  • I don't understand your thoughts about the PaletteItem interface the render method and such things.
  • I find the "select item in PSP -> select corresponding element on page" something very important so it will be nice to do this. The opposite direction seems important for consistency but it may not be so useful.

comment:7 Changed 10 years ago by meddle

  • Status changed from s2c_design_ok to s3a_implementation_started
  • Imp._reviewers set to meddle

comment:8 Changed 10 years ago by meddle

  • Status changed from s3a_implementation_started to s3b_implementation_finished
  • Imp._owners set to meddle
  • Imp._reviewers meddle deleted
  • You can rename it if you want, I have no complains about that.
  • Done for these methods, not refactored old uses though...
  • Rename it, move it as you like, the name works for me.
  • Amm I spoke with you about that, so I hope you have idea now, the caching is more general now.
  • And the selection is done :)

comment:9 Changed 10 years ago by pap

  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Imp._score changed from 0 to 4
  • Imp._reviewers set to pap, todor
  • I like what you have done but of course I cannot stay silent
  • I think the way PSP nodes are created may be made quite more extensible.
  • The current way suits the current needs but on adding new types of elements to sophie the palette will become less useful
  • An example are the text links
  • But this solution is the best for the given amount of time :) next time better
  • I especially like the way you express yourself

comment:10 Changed 10 years ago by deyan

  • Status changed from s3c_implementation_ok to closed

Batch update from file query-10.csv

Note: See TracTickets for help on using tickets.