Ticket #2146 (closed unplanned_task)
NFR_TEXT_PERFORMANCE_R0
Reported by: | kyli | Owned by: | kyli |
---|---|---|---|
Priority: | major | Milestone: | X2 |
Component: | uncategorized | Version: | 2.0 |
Keywords: | Cc: | ||
Category: | unknown | Effort: | |
Importance: | Ticket_group: | ||
Estimated Number of Hours: | 0 | Add Hours to Ticket: | 0 |
Billable?: | yes | Total Hours: | 0 |
Analysis_owners: | kyli | Design_owners: | kyli |
Imp._owners: | kyli | Test_owners: | |
Analysis_reviewers: | todor | Changelog: | |
Design_reviewers: | pap | Imp._reviewers: | meddle, todor |
Test_reviewers: | Analysis_score: | 4.5 | |
Design_score: | 3.5 | Imp._score: | 4 |
Test_score: | 0 |
Description
Change History
comment:1 Changed 15 years ago by kyli
- Owner set to kyli
- Status changed from new to s1a_analysis_started
comment:2 Changed 15 years ago by kyli
- Status changed from s1a_analysis_started to s1b_analysis_finished
comment:3 Changed 15 years ago by todor
- Status changed from s1b_analysis_finished to s1c_analysis_ok
- Milestone set to X2
- Analysis_score changed from 0 to 4.5
excellent analysis
comment:4 Changed 15 years ago by kyli
- Design_owners set to kyli
- Status changed from s1c_analysis_ok to s2a_design_started
comment:5 Changed 15 years ago by kyli
- Status changed from s2a_design_started to s2b_design_finished
comment:6 Changed 15 years ago by pap
- Status changed from s2b_design_finished to s2c_design_ok
- Design_score changed from 0 to 3.5
- Design_reviewers set to pap
2 :)
- Okay. Chaining 270 times faster seems very nice
- The size of the QueryCache you use seems targeted at some ammount of pages. Can you give some way to calculate it. Also it may be noted in a comment in the code.
- The fact that LBMs returned from the chache are always zeroed may need to be noted in the code
- The same about toAci method
- Use assertSame when you mean that and not assertEquals - don't trust auto complete so much :P
- The text of the design is a bit hard to read as it is too masive :)
comment:7 Changed 15 years ago by kyli
- Status changed from s2c_design_ok to s3a_implementation_started
- Imp._owners set to kyli
Sorry for the text :)
comment:8 Changed 15 years ago by kyli
- Status changed from s3a_implementation_started to s3b_implementation_finished
Done.
comment:9 Changed 15 years ago by meddle
- Status changed from s3b_implementation_finished to s3c_implementation_ok
- Imp._score changed from 0 to 4
- Analysis_reviewers set to todor
- Imp._reviewers set to meddle, todor
The speed is very good, I think the size of the query cache can be determined with custom testing and you played with it (I hope) enough time to be sure. I does not like that the dryRun method i s not in some TextUtility, but... I hope the task doesn't cause bugs, and I'm sorry that I can not write you better review...
If you need to change the applyChange method of the Accesses to register only one change for repeating instance of a key I'll help you, just ask...
4p
comment:10 Changed 15 years ago by deyan
- Status changed from s3c_implementation_ok to closed
Batch update from file query-10.csv
Note: See
TracTickets for help on using
tickets.