Ticket #2148 (closed unplanned_task)
EXTERNAL_LINKS_R0
| Reported by: | todor | Owned by: | deni |
|---|---|---|---|
| Priority: | major | Milestone: | X3 |
| Component: | uncategorized | Version: | 2.0 |
| Keywords: | Cc: | ||
| Category: | unknown | Effort: | |
| Importance: | Ticket_group: | ||
| Estimated Number of Hours: | 0 | Add Hours to Ticket: | 0 |
| Billable?: | yes | Total Hours: | 0 |
| Analysis_owners: | todor, deni | Design_owners: | deni |
| Imp._owners: | deni | Test_owners: | |
| Analysis_reviewers: | dido | Changelog: | |
| Design_reviewers: | pap | Imp._reviewers: | pap |
| Test_reviewers: | Analysis_score: | 4 | |
| Design_score: | 3 | Imp._score: | 3.5 |
| Test_score: | 0 |
Description
Change History
comment:1 Changed 15 years ago by todor
- Owner set to todor
- Status changed from new to s1a_analysis_started
- Analysis_owners set to todor
comment:2 Changed 15 years ago by deni
- Status changed from s1a_analysis_started to s1b_analysis_finished
- Analysis_owners changed from todor to todor, deni
comment:3 Changed 15 years ago by dido
- Status changed from s1b_analysis_finished to s1c_analysis_ok
- Analysis_reviewers set to dido
- Analysis_score changed from 0 to 4
Look fine for me, nothing to add.
Analysis Reviewed 4p (10m)
comment:4 Changed 15 years ago by deni
- Owner changed from todor to deni
- Status changed from s1c_analysis_ok to s2a_design_started
comment:5 Changed 15 years ago by deni
- Design_owners set to deni
- Status changed from s2a_design_started to s2b_design_finished
- Imp._owners set to deni
comment:6 Changed 15 years ago by pap
- Status changed from s2b_design_finished to s2c_design_ok
- Design_score changed from 0 to 3
- Design_reviewers set to pap
- It would be very nice if we had a test for the persister - it is something that is done in 6 rows and I would feel very happy if I get that for with the implementation - see http://sophie2.org/trac/changeset?new=7792%40branches%2Fprivate%2Fpap%2Fimage_hud&old=7731%40trunk%2Fsophie2-platform#file5 for example.
- In OpenUrlAction constructor you should not call super(). It is automatically called.
- I somewhat dislike the new util class but...
- It may be nice to make it final.
- I suggest improving the openUrl method a bit by using the OSUtil class and its methods
- Actually you may put the openUrl method in OSUtil.
comment:7 Changed 15 years ago by deni
- Status changed from s2c_design_ok to s3a_implementation_started
comment:8 Changed 15 years ago by deni
- Status changed from s3a_implementation_started to s3b_implementation_finished
comment:9 Changed 15 years ago by pap
- Status changed from s3b_implementation_finished to s3c_implementation_ok
- Imp._score changed from 0 to 3.5
- Imp._reviewers set to pap
- Put braces on if statements in auto-generated equals methods
- The control for entering the URL is quite unusable but obviously we have some focusing problems. Or actually link hud controls recomputing.
- Otherwise I am glad, especially about the test :)
comment:10 Changed 15 years ago by deyan
- Status changed from s3c_implementation_ok to closed
Batch update from file query-10.csv
Note: See
TracTickets for help on using
tickets.
