Bugs related to timelines hud & palette

[deni]

• OFF phase for a child element cannot be chosen from Timelines Hud
  • Steps to reproduce:
    • Open the timelines hud on a page with at least one frame;
    • Choose OFF for the child frame;
    • An exception will be thrown.
  • Expected behaviour when an element is OFF:
    • It is not visible in preview mode or reader at the specified moment.
    • It is OK that its location in author is (0, 0).
    • The line in the activation channel for the element at the time when it is off, can be at the bottom of the green rectangle.

• The size of timelines hud is not recomputed appropriately.
  • Steps to reproduce:
    • Add a few (more that 3) frames on a single page.
    • Open the page timelines hud.
    • The 4th frame will not be visible.
  • Expected behavior:
    • The childs section (and the hud) grows bigger, as the user inserts new frames.

• The play head slider of timelines palette is not always aligned with the visibility and activation channels.
  • Steps to reproduce:
    • Show the bottom panel;
    • Open the timelines hud of the current page and change the intro length to 0, the main phase length to 60 000 and the outro length to 0.
    • The slider will become shorter and will be centered and not aligned with the channels under it.
  • Expected behavior:
    • The slider should be left aligned, like the channels.

[pap]

Finished by deni

[pap]

• Case 1) - Inactive frames should not have green . They should be with some other color (black ?? ). Otherwise - OK
• (case 2) - This might have already been resolved. But you may have a better solution.
• OK :)

[deni]

• Choosing OFF phase from timelines hud:
  • In TimelinesPalette's drawActivationContents when calculating the y-coordinate of the start point where to draw on the graphics, add a simple check whether the phase is OFF. If so, use y = 0.
  • In ElementView make elementViews() property to use ElementH.getSubElements() instead of ElementH.getChildElements(long). This will add all children elements, including those that are not active at the moment.

• Computing the size of timelines hud:
  • The problem does not occur every time now, but it still exists.
  • I think the real problem is in an unnecessary check in ChildSection.computeSize() and HudDialog.computeSize(). Consider the following scenario:
    • We have a page with 5 frames and one of them is selected. Then the user selects the page.
    • ElementHud's context property changes to the appropriate MainPageView.
    • ChildSection's subElements property updates.
    • ChildSection.swingComponent()...setup(JPanel) depends on it to compute the size of the swing element. So the computeSize() method is invoked.
    • Note that in this scenario, the ChildSection.swingComponent()...setUpSubElements(JPanel) method has not yet been invoked. This means that the swing elements of the ChildRows have not yet been included in the JPanel of ChildSection. Therefore their getLocation() method will return (0, 0). As a result only one of them will be considered when calculating the height of ChildSection' panel.
    • ChildSection.swingComponent()...setUpSubElements(JPanel) also depends on ChildSection's subElements property and will be invoked. It will add the elements, but this will not influence the size of the panel.
  • Remove the following snippet from ChildSection.swingComponent()...setUpSubElements(JPanel) and ChildRow.swingComponent()...setup(JPanel), because it is pointless:

    if(parent().get() != null) {
          parent().get().swingComponent().get().add(res);
    }
    

• Play head slider alignment:
  • Set left alignment to playHeadPanel() in TimelinesPalette by adding FlowLayout(FlowLayout.LEFT) layout manager when creating the JPanel

• Change the sizes of all spinners in timelines hud to be big enough for out default values:
  • Move synchronizing the input control size out of the method that synchronizes the model data in BoundSpinner .
  • Add the appropriate sizes in HeadSection and ChildSection .

• Add a tooltip for TimelinesHud .
  • I don't know why, but this fixed the problem that you can select frames that are under the hud.

• I don't know what to do with TimelinesPalette.playHead()...setupPos(JSlider) :-(

• Source code: [8082]

[deni]

• I gave you a wrong revision, sorry...
• The correct one is [8084]

[deni]

More fixes:

• Open the timelines hud on a page with 3 frames and change the phase of the second frame using the combo box. The frames will be reordered in the hud. Besides, their zOrder will change.
  • The problem is in ChildRow.ChildRowLogic.createActivationChannels(Phase, Integer, ResourceAccess, ChildRow) .
    • Currently it reorders the activation channels of the page elements.
    • Instead, it should find the index of the activation channel it wants to change, and replace it.

• Source code: [8086]

• If you click on an element that is OFF, an exception will be thrown that the timelines palette does not know where its play head should be situated.
  • After a discussion with the integrators, we decided that elements that are not on, should not be visited in author mode, too.
  • This should be done in ElementView.sceneElement().sceneElement...setupElements()

[pap]

• Commited in [5090]
• I still find the solution with sizing huds and ChildSection a bit risky :) depending on the layout. But I understood the problem :) 10x
• I am a bit sad that you didn't manage to synchronize the slider
• I dislike that ActivationChannels are still painted improperly.
• But generally I am quite glad with the result

[deyan]

Batch update from file query-10.csv