link-actions-control-media - Play, stop and pause for the media frames

[deyan]

provide the following link actions:

• media play;
• media rewind;
• media stop;
• media pause.

The user should be abble to choose the media frame from a combo box.
The media frames are from the current page.

[deyan]

Batch update from file priorities.csv

[diana]

In order to provide the wanted functionality the following classes were dded:
In org.sophie2.main.func.links.actions.navigation package:

• abstract class MediaAction extends LinkAction implements ResourceRefWrapper - represents all the link actions related to media(play,pause,rewind and stop).
• class MediaPauseAction - the class representing the pause media link action.
• class MediaPlayAction - the class representing the play media action.
• class MediaRewindAction - the class representing the rewind media action.
• class MediaStopAction - the class representing the stop media action.

In org.sophie2.main.func.links.actions.showing package:

• class LinkActionUtil - helper class for media link logic.
• class MediaPauseProvider - class for creating MediaPauseAction-s.
• class MediaPlayProvider - class for creating mediaPlayAction-s.
• class MediaRewindProvider - class for creating MediaRewindAction-s.
• class MediaStopProvider - class for creating MediaStopAction-s.
• enum MediaActionLogic implements OperationDef - provides the logic for stopping,rewinding,playing and pausing the cosen media frame view.
• abstract class MediaActionConfigurationPanel - the configuration panel for all the media link actions.(the getActionClass function is abstract).
• class PlayMediaConfigurationPanel extends MediaActionConfigurationPanel - the configuration panel for MediaPlayAction.
• class PauseMediaConfigurationPanel extends MediaActionConfigurationPanel - the configuration panel for MediaPauseAction.
• class RewindMediaConfigurationPanel extends MediaActionConfigurationPanel - the configuration panel for MediaRewindAction.

• class StopMediaConfigurationPanel extends MediaActionConfigurationPanel - the configuration panel for MediaStopAction.

In org.sophie2.main.func.links.persist package:

• StopMediaActionPersister - the persister for MediaStopAction.
• PlayMediaActionPersister - the persister for MediaplayAction.
• PauseMediaActionPersister - the persister for MediaPauseAction.
• RewindMediaActionPersister - the persister for MediaRewindAction.

source code: [8196]

[deyan]

Batch update from file report_1.csv

[diana]

source code: [8196] [8206]

[deyan]

Make sure when the target is deleted, the link is converted to a link without target - as in "toggle frame" for example.

[deyan]

Batch update from file 0911261.csv

[pap]

• Generally I don't like it how it looks, but I'm passing it as I hope it will improve at least a little until implemented.
• First of all I think that media actions should be in the media func module because they are senseless without it. So please be so kind to move them there.
• Second I dislike the util you created. Its name is bad because it is not for all action but only for media ones. Also there lots of utility classes in sophie that are unknown to the developers and stay unused. We dont't need the next such. It would much better live in the MediaActionsLogic itself.
• I suggest setting the state for the whole media channel instead from the current moment to the end(Deyan agreed with that). This way you may use the access only in some actions and not search for the view.
• I think that your way of pausing is incorrect as you set MediaState.DEFAULT_STOPPED which might rewind the media but not pause in its current state. Recheck all states you set.
• Also double-check whether your actions work correctly with page, frame and especially text links.
• This is something that is not your fault, but we don't need the context ResourceView when triggering links since we have the ResourceAccess parameter. So I strongly advise you not to depend on the ResourceView. It is to be removed.
• Also I find that adding new actions seems like lots of the same code for everything - actions , providers and persisters. Cant't we simplify this.. ? Especially the persisters.
• It seems that you don't reuse what you already have - getting media state channels several times in the logic.

[diana]

Changes made:
Make a new package: org.sophie2.main.func.media.links and move all the listed classes there.
Remove the LinkActionUtil class.

[diana]

source code: [8196] [8243]

[pap]

• Nice that we have these new abilities.
• Malformed JavaDoc - misplaced newlines.
• Some bad spacing in if statements.
• Calling "super()" in a constructor is meaningles. This is done by default. (MediaAction class)
• You could use @VisualElementDef + AutoVisualProvider for MediaActionConfigurationPanel.MediaFrameSelector
• Anonymous ValueRefs and getInitial. Read the updated JavaDoc of ValueRef on that issue :)
• I like that you made MediaAction to hold some common logic. It would be great if we had this feature for all link actions :)
• Commited to trunk in [8278].

[meddle]

Closing all the tickets before M Y1