Ticket #2178 (closed feature: fixed)

Opened 15 years ago

Last modified 15 years ago

link-actions-go-to-prev-page - Go to previous page link action

Reported by: deyan Owned by: diana
Priority: critical Milestone: X3
Component: uncategorized Version: 2.0
Keywords: Cc: diana
Category: unknown Effort: 1
Importance: 86 Ticket_group:
Estimated Number of Hours: 0 Add Hours to Ticket: 0
Billable?: yes Total Hours: 0
Analysis_owners: Design_owners: diana
Imp._owners: diana Test_owners:
Analysis_reviewers: Changelog:
Design_reviewers: pap Imp._reviewers: deyan, pap
Test_reviewers: Analysis_score: 0
Design_score: 4 Imp._score: 3
Test_score: 0

Description (last modified by deyan) (diff)

Add a "Go to previous page" link action that acts like go to next page, but for previous page. Make sure nothing happens when the link is on page 1.

Change History

comment:1 Changed 15 years ago by deyan

  • Importance changed from 80 to 86
  • Summary changed from link-actions-go-to-prev-page to link-actions-go-to-prev-page -- „Go to previous page“ link action

Batch update from file report_1.csv

comment:2 Changed 15 years ago by deyan

  • Category set to unknown
  • Status changed from new to s1a_analysis_started
  • Description modified (diff)
  • Analysis_score set to 0
  • Test_score set to 0
  • Design_score set to 0
  • Owner set to deyan
  • Imp._score set to 0

comment:3 Changed 15 years ago by deyan

  • Status changed from s1a_analysis_started to s1b_analysis_finished

comment:4 Changed 15 years ago by deyan

  • Priority changed from major to critical
  • Summary changed from link-actions-go-to-prev-page -- „Go to previous page“ link action to link-actions-go-to-prev-page -- „Go to previous page“ link action

Batch update from file 0911261.csv

comment:5 Changed 15 years ago by todor

  • Summary changed from link-actions-go-to-prev-page -- „Go to previous page“ link action to link-actions-go-to-prev-page - Go to previous page link action

comment:6 Changed 15 years ago by diana

  • Design_owners set to diana
  • Imp._owners set to diana

In order to provide the wanted functionality the following classes were added:

In org.sophie2.main.func.links.actions.navigation package:

  • PrevPageAction extends LinkAction - represents the "previous page" action.
  • PrevPageProvider - the provider for the PrevPageAction-s. In org.sophie2.main.func.links.persist package:
  • PrevPageActionPersister - the persister for the PrevPageAction-s.

In NavigationActionsLogic class add ON_GO_TO_PREV_PAGE - the logic for the PrevPageAction-s.
source code: [8218]

comment:7 Changed 15 years ago by diana

  • Status changed from s1b_analysis_finished to s1c_analysis_ok

comment:8 Changed 15 years ago by diana

  • Owner changed from deyan to diana
  • Status changed from s1c_analysis_ok to s2a_design_started

comment:9 Changed 15 years ago by diana

  • Status changed from s2a_design_started to s2b_design_finished

comment:10 Changed 15 years ago by pap

  • Status changed from s2b_design_finished to s2c_design_ok
  • Design_score changed from 0 to 4
  • Design_reviewers set to pap
  • OK

comment:11 Changed 15 years ago by diana

  • Status changed from s2c_design_ok to s3a_implementation_started

comment:12 Changed 15 years ago by diana

  • Status changed from s3a_implementation_started to s3b_implementation_finished

comment:13 Changed 15 years ago by pap

  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Imp._score changed from 0 to 3
  • Imp._reviewers set to deyan, pap
  • The implementation was not very good.
  • The @Immutable kind of the action was "next-page-action" which broke the persistence of such actions ( they were loaded as GoToNextPage)
  • The description in the provider was "go to prev page" which is not really nice - "Go to previous page" is better.
  • The would be better if "go to previous page" appears before "go to next page" in the HUD. This was achieved by changing the orders of the extensions in the LinksModule. This is not a 100% solution but generally works.
  • But I want to mention that the effect that can be achieved is awesome (on page shown go to next page : on page shown go to previous page). Really amazing :)
  • Commited to trunk in [8233].

comment:14 Changed 15 years ago by pap

  • Cc diana added

adding cc

comment:15 Changed 15 years ago by deyan

  • Status changed from s3c_implementation_ok to closed
  • Resolution set to fixed

fixed

Note: See TracTickets for help on using tickets.