Ticket #220 (closed planned_task: obsolete)
CORE_LOGGING_R1
| Reported by: | Astea | Owned by: | deni |
|---|---|---|---|
| Priority: | 3 | Milestone: | M04_PRE4 |
| Component: | CORE_FUNDAMENTALS | Version: | 2.0 |
| Keywords: | Cc: | deni | |
| Category: | CORE | Effort: | 2 |
| Importance: | 20 | Ticket_group: | |
| Estimated Number of Hours: | Add Hours to Ticket: | ||
| Billable?: | Total Hours: | ||
| Analysis_owners: | deni | Design_owners: | deni |
| Imp._owners: | Test_owners: | ||
| Analysis_reviewers: | meddle | Changelog: | |
| Design_reviewers: | meddle | Imp._reviewers: | meddle |
| Test_reviewers: | Analysis_score: | 3.5 | |
| Design_score: | 3 | Imp._score: | 3 |
| Test_score: | 0 |
Description
wiki page: CORE_LOGGING_R1 - effort: 2d
Change History
comment:1 Changed 16 years ago by peko
- Owner changed from Astea to peko
- Design_score set to 0
- Imp._score set to 0
- Test_score set to 0
- Analysis_score set to 0
comment:5 Changed 16 years ago by peko
- Status changed from s1a_analysis_started to s1b_analysis_finished
comment:7 Changed 16 years ago by deni
- Owner changed from peko to deni
- Status changed from new to s1a_analysis_started
comment:8 Changed 16 years ago by deni
- Status changed from s1a_analysis_started to s1b_analysis_finished
comment:9 Changed 16 years ago by meddle
- Status changed from s1b_analysis_finished to s1c_analysis_ok
- Analysis_reviewers set to meddle
- Analysis_owners set to deni
- Analysis_score changed from 0 to 3.5
Works for me, it's clear.
Write yourself as a owner of the design!.
3.5p (10m)
comment:10 Changed 16 years ago by deni
- Design_owners set to deni
- Status changed from s1c_analysis_ok to s2a_design_started
comment:11 Changed 16 years ago by deni
- Status changed from s2a_design_started to s2b_design_finished
comment:12 Changed 16 years ago by meddle
- Status changed from s2b_design_finished to s2c_design_ok
- Design_score changed from 0 to 3
- Design_reviewers set to meddle
Design related notes:
- Rename StackStaceElement to StackTraceElement in the design documentation :)
- In your UML diagram the SophieLog table don't include the formated message methods, but that is not a big problem.
- You wrote "A new package will be created - org.sophie2.core.logging ", but you will create a new module! Fix that line!
- You know that especially when you create new modules the project MUST be buildable with maven and runnable with no exceptions with all of the three true runners:
- Author
- Reader
- Server
- You know that especially when you create new modules the project MUST be buildable with maven and runnable with no exceptions with all of the three true runners:
Code related notes (An the implementation review this thing MUST be fixed!)
- Write your name with small letter when you fill the @author field! All of us do that.
- You know my opinion about the sentences in the JavaDoc :D This is optional ofcaurse but it will be a pleasure for me if you write all the @param and @return expressions to begin with Capital letter and to end with a dot.
- You have implemented binSearch method... Hmm I thingin the JDK there is such implementations that use comparators, but... Your will :)
- Ummm "Just testing..." is veeeeery bad comment for a UnitTest, FIX IT!
- Hmmm deni, LoggerTest is not a test, may be it is demo, or may be is something temporary used by you to try out some stuff... If it is a demo, rename it to LoggerDemo, if it's something temporary delete it.
- All @param expressions in the JavaDoc MUST be commented!
- Indent you code (Ctrl+i)!
- In the StreamLogTarget you pack the OutputStream with a PrintWriter, why is that necessary??
- When you have exceptions in the logger don't use Exception#printStackTrace();, throw RuntimeExceptions!
- What the hell is this LoggingExperiments passed for the design review??? Delete it!
Test related notes:
- Don't use java assertations in your tests! Use assertTrue or assertFalse from the JUnit library! That is a big mistake, the next time I'll will fail the design for that!
Sooo I'll pass this design, but for the implementation review be sure to fix all the thing I wrote you.
3p (50m)
comment:14 Changed 16 years ago by deni
- Status changed from s2c_design_ok to s3a_implementation_started
comment:15 Changed 16 years ago by deni
- Status changed from s3a_implementation_started to s3b_implementation_finished
comment:16 Changed 16 years ago by meddle
- Status changed from s3b_implementation_finished to s3c_implementation_ok
- Imp._score changed from 0 to 3
- Imp._reviewers set to meddle
Will pass...
comment:17 Changed 15 years ago by deyan
- Status changed from s3c_implementation_ok to closed
- Resolution set to obsolete
Batch update from file query-obsoleted.csv
Note: See
TracTickets for help on using
tickets.
