Ticket #2211 (closed bug: obsolete)

Opened 10 years ago

Last modified 8 years ago

search-in-the-book - The Search palette doesn't work properly.

Reported by: todor Owned by: diana
Priority: major Milestone: X3
Component: uncategorized Version: 2.0
Keywords: Cc:
Category: unknown Effort:
Importance: 90 Ticket_group:
Estimated Number of Hours: 0 Add Hours to Ticket: 0
Billable?: yes Total Hours: 0
Analysis_owners: todor Design_owners: diana
Imp._owners: diana Test_owners:
Analysis_reviewers: diana Changelog:
Design_reviewers: meddle Imp._reviewers: meddle, deyan
Test_reviewers: Analysis_score: 0
Design_score: 3 Imp._score: 3
Test_score: 0

Description (last modified by todor) (diff)

Search has inconsistent and unpredictable behavior, and some of its features don't work at all.

  • Sometimes search misses results or find results only in the current page/flow.
  • The number before the result must show the page number on which the result is found (now only 1 is displayed).
  • The previous and next result button doesn't behave consistently this maybe is result of the problem explained in the upper bullet.

Change History

comment:1 Changed 10 years ago by todor

  • Status changed from new to s1b_analysis_finished

comment:2 Changed 10 years ago by todor

  • Description modified (diff)

comment:3 Changed 10 years ago by diana

  • Status changed from s1b_analysis_finished to s2a_design_started

In org.sophie2.main.func.text.search package add a new helper class SearchTextUtility in order to help searching a word in a given ImmHotText.
Move two of the search methods hrom HeadTextFrameView to the SearchTextUtility and make the search(ImmHotText longText,String string, HotPos start,

int maxResults, List<HotPos> res) function ignore the upper and lower letters in the text.

Add new searchInArea function that searches in the given areaNumber from a chained text views.
In TailTextFrameView:search search the text from the current tail text frame view area.
In TailTextFrameView:search search the text from the text placed in the area with number = 0.

comment:4 Changed 10 years ago by diana

  • Design_owners set to diana
  • Status changed from s2a_design_started to s2b_design_finished
  • Imp._owners set to diana

spurce code: [8336]

comment:5 Changed 10 years ago by meddle

  • Status changed from s2b_design_finished to s2c_design_ok
  • Design_score changed from 0 to 3
  • Design_reviewers set to meddle
  • Analysis_reviewers set to diana

Amm that is your design for the search... you talked with Milo I see.

  • I don't like that the function ignores the case... I think it should take in mind the case, because in future there will be case sensitive search... May be the method has to have a Boolean variable 'ignoreCase' and in the moment it should be called always with true...
  • The sentence 'In TailTextFrameView:search search the text from the text placed in the area with number = 0.' should be about HeadTextFrame, or?
  • The branch thing I will not comment, because we talk about the reintegration for months now, but we are disappointed.
  • When you take a bug, you perform analysis review, which is if you understand what is wrong, so you are the analysis reviewer here, write mark and your name as such in the future...

3p

comment:6 Changed 10 years ago by diana

  • Owner set to diana
  • Status changed from s2c_design_ok to s3a_implementation_started

In HeadTextFrameView:search search the text from the text placed in the area with number = 0.
source code: [8341]

comment:7 Changed 10 years ago by diana

  • Status changed from s3a_implementation_started to s3b_implementation_finished

comment:8 Changed 10 years ago by meddle

  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Imp._score changed from 0 to 3
  • Imp._reviewers set to meddle, deyan

Merged to the trunk at [8344]... Identation, spaces, bla, bla bla and slowness, but that is a problem for another bug I guess...

3p

comment:9 Changed 8 years ago by meddle

  • Status changed from s3c_implementation_ok to closed
  • Resolution set to obsolete

Closing all the tickets before M Y1

Note: See TracTickets for help on using tickets.