Ticket #2226 (closed bug: obsolete)
style-changes-undo -- Undo does not discard text style changes
Reported by: | deyan | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | X3 |
Component: | uncategorized | Version: | 2.0 |
Keywords: | Cc: | ||
Category: | unknown | Effort: | |
Importance: | 50 | Ticket_group: | |
Estimated Number of Hours: | 0 | Add Hours to Ticket: | 0 |
Billable?: | yes | Total Hours: | 0 |
Analysis_owners: | deyan | Design_owners: | diana |
Imp._owners: | diana | Test_owners: | |
Analysis_reviewers: | diana | Changelog: | |
Design_reviewers: | pap | Imp._reviewers: | pap, todor |
Test_reviewers: | Analysis_score: | 4.5 | |
Design_score: | 3 | Imp._score: | 3 |
Test_score: | 0 |
Description
Enter some text, change font size; Try to undo, nothing happens.
Attachments
Change History
comment:2 Changed 15 years ago by deni
- Design_owners set to deni
- Status changed from s1b_analysis_finished to s2a_design_started
- Imp._owners set to deni
- Analysis_reviewers set to deni
comment:3 Changed 15 years ago by deni
- Design_owners deni deleted
- Status changed from s2a_design_started to new
- Imp._owners deni deleted
- Analysis_reviewers deni deleted
comment:4 Changed 15 years ago by diana
- Design_owners set to diana
- Status changed from new to s1b_analysis_finished
- Imp._owners set to diana
- Analysis_score changed from 0 to 4.5
- In TextView:EventIds:SET_TEXT add a new boolean parameter. If the parameter is true - the undo considers the fastness of typing (when undo all the changes applied in some time interval are undo), if false - the undo considers only the last change.
- In HotTextLogic:ON_SET_TEXT if the boolean parameter of the event is lase, then the old text is set again to the model and is registered as a significant change and the applying of the new text is set as a significant change.
NOTE: This is VERY ugly...and I don't like the fix but cannot think of another...
comment:5 Changed 15 years ago by diana
- Status changed from s1b_analysis_finished to s2a_design_started
comment:6 Changed 15 years ago by diana
- Status changed from s2a_design_started to s3b_implementation_finished
comment:7 Changed 15 years ago by pap
- Status changed from s3b_implementation_finished to s3c_implementation_ok
- Analysis_reviewers set to diana
- Imp._reviewers set to pap, todor
- Design_score changed from 0 to 3
- Design_reviewers set to pap
- Imp._score changed from 0 to 3
- Commited to trunk in [8605]
- No need to set the current text again. Just put an empty AutoAction that is significant.
- I find the naming a bit bad.
- Copy/paste in the JavaDoc of the new parameter index constant is not fixed.
- As I said you didn't use the new parameter corectly in places different than the style changes.
- You left a commented out println :)
- Your English is strangely strange in this ticket - both in the JavaDoc and in the explanation in the comments.
- Write yourself as an analysis reviewer
Note: See
TracTickets for help on using
tickets.