Ticket #2228 (closed bug: obsolete)

Opened 15 years ago

Last modified 13 years ago

Closing master accesses

Reported by: mira Owned by: mira
Priority: major Milestone:
Component: BASE_RESOURCE_MODEL Version: 2.0
Keywords: Cc:
Category: unknown Effort:
Importance: Ticket_group:
Estimated Number of Hours: 0 Add Hours to Ticket: 0
Billable?: yes Total Hours: 0
Analysis_owners: mira Design_owners: mira
Imp._owners: mira Test_owners:
Analysis_reviewers: meddle Changelog:
Design_reviewers: meddle Imp._reviewers: meddle, todor, meddle, todor
Test_reviewers: Analysis_score: 4
Design_score: 4 Imp._score: 4
Test_score: 0

Description

The master accesses are never closed and this leads to saving the state of the book even when all views to it are closed.

Attachments

closeMasterAccesses.patch (22.0 KB) - added by mira 15 years ago.

Change History

comment:1 Changed 15 years ago by mira

  • Status changed from new to s1b_analysis_finished

comment:2 Changed 15 years ago by mira

  • Design_owners set to mira
  • Status changed from s1b_analysis_finished to s2a_design_started

comment:3 Changed 15 years ago by mira

  • Status changed from s2a_design_started to s2b_design_finished

Since the views are updated even when closed removing delegating accesses will not do the trick.

Add a flag to the BaseResourceAccess - closed. Its initial value should be false. There will be no setter with argument. Add a method that closes this access, i.e sets the flag to true. Add also a method that checks whether an access is closed - this is true if its closed value is true, or any of its parents.

When closing a delegating access check if all accesses in this group(delegating to this master) are closed and in this case - close the master also.

Change the viewid of the AccessOptions when reopening book due to a SAVE_AS.

comment:4 Changed 15 years ago by mira

  • Status changed from s2b_design_finished to s2c_design_ok

comment:5 Changed 15 years ago by mira

  • Owner set to mira
  • Status changed from s2c_design_ok to s3a_implementation_started
  • Design_reviewers set to mira
  • Imp._owners set to mira

comment:6 Changed 15 years ago by mira

  • Status changed from s3a_implementation_started to s3b_implementation_finished

comment:7 Changed 15 years ago by meddle

  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Analysis_reviewers set to meddle
  • Analysis_score changed from 0 to 2
  • Imp._reviewers set to meddle, todor
  • Design_score changed from 0 to 2
  • Design_reviewers changed from mira to meddle
  • Imp._score changed from 0 to 2

I'll fail the task:

  • The server books are not cleared from the cache...
  • When we save book over already opened book the exception with the 'already created resource' still occurs, it's normal that to be impossible, but the exception is not an option, show some message instead.

comment:8 Changed 15 years ago by pap

  • Status changed from s3c_implementation_ok to s2c_design_ok
  • super reviewing to fix wrong transition

comment:9 Changed 15 years ago by mira

  • Status changed from s2c_design_ok to s3a_implementation_started

Changed 15 years ago by mira

comment:10 Changed 15 years ago by mira

  • Status changed from s3a_implementation_started to s3b_implementation_finished

comment:11 Changed 15 years ago by meddle

  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Design_score changed from 2 to 4
  • Imp._reviewers changed from meddle, todor to meddle, todor, meddle, todor
  • Imp._score changed from 2 to 4
  • Analysis_score changed from 2 to 4

Merged into the trunk at [8348].

4p

comment:12 Changed 13 years ago by meddle

  • Status changed from s3c_implementation_ok to closed
  • Resolution set to obsolete

Closing all the tickets before M Y1

Note: See TracTickets for help on using tickets.