Ticket #2318 (closed bug: obsolete)

Opened 9 years ago

Last modified 8 years ago

more than one text link not allowed

Reported by: danvisel Owned by: deni
Priority: major Milestone: X3
Component: uncategorized Version: 2.0
Keywords: Cc: deni
Category: unknown Effort:
Importance: 90 Ticket_group:
Estimated Number of Hours: 0 Add Hours to Ticket: 0
Billable?: yes Total Hours: 0
Analysis_owners: danvisel Design_owners: deni
Imp._owners: deni Test_owners:
Analysis_reviewers: deni Changelog:
Design_reviewers: meddle, pap Imp._reviewers: todor, pap
Test_reviewers: Analysis_score: 4.5
Design_score: 3.5 Imp._score: 4
Test_score: 0

Description

  1. Open Sophie.
  2. Make a new book.
  3. Insert a new text frame. Type in the text: "This is my first link. This is my second link."
  4. Highlight "first link" and make a link to go to previous page on mouse enter.
  5. Highlight "second link" and open the link HUD.

What happens: the first link appears in the link HUD. This should not be the case, because this should be a second link.

  1. Add a new link on "second link" that goes to next page on mouse leave.

When the link is added to the second link, it replaces the first link. If you go back to the first link, you'll see that it has been replaced by the second link.

This is a very serious bug: in most cases where people are going to be using long text, they're going to want to have more than one link in it, which this prevents.

Attachments

more-than-one-text-link.patch (2.0 KB) - added by deni 9 years ago.

Change History

comment:1 Changed 9 years ago by danvisel

  • Status changed from new to s1b_analysis_finished

comment:2 Changed 9 years ago by dido

  • Importance set to 90

comment:3 Changed 9 years ago by deni

  • Status changed from s1b_analysis_finished to s2a_design_started

comment:4 Changed 9 years ago by deni

  • Design_owners set to deni
  • Imp._owners set to deni
  • Analysis_reviewers set to deni
  • Analysis_score changed from 0 to 4.5

comment:5 Changed 9 years ago by deni

  • Status changed from s2a_design_started to s3b_implementation_finished
  • In fact there is no problem with the links themselves. If you open preview, they will be working as expected. The real problem is that the hud doesn't update the current rule when you change the text selection.
  • A possible solution is to add holder().get().getLink() in the setup method of currentRuleSync().


  • If you have a link atthached to the text "first link" and you select the text "first", in the hud you'll see the link. This is incorrect.
    • Fix HotInterval.getComparator(Comparator<HotPos>) to take into account both the beginnings and the ends of the compared HotIntervals.
    • Remove ImmHotText.getIntervalComparator, because it does the same thing.

comment:6 Changed 9 years ago by meddle

  • Cc deni added
  • Status changed from s3b_implementation_finished to s1c_analysis_ok
  • Design_reviewers set to meddle

The patch can be applied... failing...

comment:7 Changed 9 years ago by deni

  • Owner set to deni
  • Status changed from s1c_analysis_ok to s2a_design_started

comment:8 Changed 9 years ago by deni

  • Status changed from s2a_design_started to s3b_implementation_finished
  • The design remains almost the same - I just decided to leave the ImmHotText.getIntervalComparator in order to avoid conflicts with the text team, but make it use HotInterval.getComparator(Comparator<HotPos>)

Changed 9 years ago by deni

comment:9 Changed 9 years ago by pap

  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Design_score changed from 0 to 3.5
  • Design_reviewers changed from meddle to meddle, pap
  • Imp._score changed from 0 to 4
  • Imp._reviewers set to todor, pap
  • Commited in [8650]
  • Seems ok but this way we will have some unnecessary updates as you know :)

comment:10 Changed 8 years ago by meddle

  • Status changed from s3c_implementation_ok to closed
  • Resolution set to obsolete

Closing all the tickets before M Y1

Note: See TracTickets for help on using tickets.