Ticket #2320 (closed bug: obsolete)

Opened 9 years ago

Last modified 8 years ago

browser frame URL must have two dots in it

Reported by: danvisel Owned by:
Priority: minor Milestone: X3
Component: uncategorized Version: 2.0
Keywords: Cc:
Category: unknown Effort:
Importance: 70 Ticket_group:
Estimated Number of Hours: 0 Add Hours to Ticket: 0
Billable?: yes Total Hours: 0
Analysis_owners: danvisel Design_owners: deni
Imp._owners: deni Test_owners:
Analysis_reviewers: deni Changelog: Changelog
Design_reviewers: meddle Imp._reviewers: meddle, todor
Test_reviewers: Analysis_score: 4
Design_score: 4 Imp._score: 4
Test_score: 0

Description (last modified by danvisel) (diff)

  1. Open Sophie.
  2. Make a new book.
  3. Insert a browser frame.
  4. Click on the browser halo to open the browser HUD.
  5. Try to enter the URL "http://sophie2.org"

Right now, URLs used in the browser need to have two dots - so "http://www.sophie2.org" would be fine and "http://dev.sophie2.org" would also be fine, but "http://sophie2.org" isn't allowed (even though that's a valid URL). I don't think we should be checking for this; this comes up during demos, where the temptation is to write a URL very quickly.

Attachments

browser-frame-url-validation.patch (763 bytes) - added by deni 9 years ago.

Change History

comment:1 Changed 9 years ago by danvisel

  • Status changed from new to s1b_analysis_finished

comment:2 Changed 9 years ago by danvisel

  • Description modified (diff)

comment:3 Changed 9 years ago by dido

  • Importance set to 70

comment:4 Changed 9 years ago by deni

  • Design_owners set to deni
  • Status changed from s1b_analysis_finished to s2a_design_started
  • Imp._owners set to deni
  • Analysis_reviewers set to deni
  • Changelog set to [wiki:Changelog]
  • Analysis_score changed from 0 to 4

Changed 9 years ago by deni

comment:5 Changed 9 years ago by deni

  • Status changed from s2a_design_started to s3b_implementation_finished
  • I think we should change the regular expression for checking whether a String is a valid URL to the following: ".{3,}[.].{2,}", i.e. 3 or more characters followed by a . and then 2 or more characters.
  • It is very simple and accepts strings such as "example..com", but in this case it is better to allow an invalid value than to forbid a valid one.

comment:6 Changed 9 years ago by meddle

  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Design_score changed from 0 to 4
  • Design_reviewers set to meddle
  • Imp._score changed from 0 to 4
  • Imp._reviewers set to meddle, todor

Merged on the trunk at [8717]. Good

comment:7 Changed 8 years ago by meddle

  • Status changed from s3c_implementation_ok to closed
  • Resolution set to obsolete

Closing all the tickets before M Y1

Note: See TracTickets for help on using tickets.