Ticket #2355 (closed bug: obsolete)

Opened 10 years ago

Last modified 9 years ago

resource-delete -- Cannot delete resources from books

Reported by: deyan Owned by:
Priority: major Milestone: X3
Component: uncategorized Version: 2.0
Keywords: Cc:
Category: unknown Effort:
Importance: 95 Ticket_group:
Estimated Number of Hours: 0 Add Hours to Ticket: 0
Billable?: yes Total Hours: 0
Analysis_owners: deyan Design_owners: deni
Imp._owners: deni Test_owners:
Analysis_reviewers: deni Changelog: Changelog
Design_reviewers: meddle Imp._reviewers: deyan, todor, meddle
Test_reviewers: Analysis_score: 3.5
Design_score: 4 Imp._score: 4
Test_score: 0

Description

In 2.0.4 an exception is trown when trying to delete an unused resource from the resource palette

Attachments

resource-delete-exceptions.patch (4.3 KB) - added by deni 10 years ago.

Change History

comment:1 Changed 10 years ago by deyan

  • Status changed from new to s1b_analysis_finished

comment:2 Changed 10 years ago by deni

  • Status changed from s1b_analysis_finished to s2a_design_started

comment:3 Changed 10 years ago by deni

  • Design_owners set to deni
  • Imp._owners set to deni
  • Analysis_score changed from 0 to 3.5
  • An exception is thrown sometimes, not always. Besides, there are different exceptions thrown in different situations.

comment:4 Changed 10 years ago by deni

  • Status changed from s2a_design_started to s3b_implementation_finished
  • An exception is sometimes thrown when we have several open books:
    • In ResourceDeleteLogic.ON_DELETE_RESOURCE we should use AppViewUtil.getCurrentBookDocView(palette) instead of palette.findNearestElement(null, BookDocView.class) to get the current book doc view.
  • An exception is thrown when trying to delete a group:
    • In GroupHalosLogic.ON_GROUP_DELETED the arguments passed to ResourceRefR4.getRelativeRef(ResourceRefR4, ResourceRefR4) should be swapped.
  • In CopyUtil.decapsulate(...) the reference passed when decapsulating the children resources was wrong - it should be the child reference appended to the current one, not just the child reference. This didn't cause any visible problems but it really was wrong :-).
  • I changed FileListData.textURIListToFileList(String) to use String.split(String) instead of StringTokenizer. Please test it on Linux.

Changed 10 years ago by deni

comment:5 Changed 10 years ago by meddle

  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Analysis_reviewers set to deni
  • Imp._reviewers set to deyan, todor, meddle
  • Design_score changed from 0 to 4
  • Design_reviewers set to meddle
  • Imp._score changed from 0 to 4

Merged to the trunk at [8854].
I think under Linux there is no problem now.
Good that you commented the analysis and mark it - so you are the analysis reviewer?

comment:6 Changed 9 years ago by meddle

  • Status changed from s3c_implementation_ok to closed
  • Resolution set to obsolete

Closing all the tickets before M Y1

Note: See TracTickets for help on using tickets.