Ticket #2375 (closed bug: obsolete)

Opened 15 years ago

Last modified 13 years ago

changing deleted element in server book

Reported by: mira Owned by: mira
Priority: major Milestone:
Component: uncategorized Version: 2.0
Keywords: Cc:
Category: unknown Effort:
Importance: Ticket_group:
Estimated Number of Hours: 0 Add Hours to Ticket: 0
Billable?: yes Total Hours: 0
Analysis_owners: mira Design_owners: mira
Imp._owners: mira Test_owners:
Analysis_reviewers: meddle Changelog: Changelog
Design_reviewers: meddle Imp._reviewers: meddle, todor, deyan
Test_reviewers: Analysis_score: 3
Design_score: 4 Imp._score: 4
Test_score: 0

Description (last modified by mira) (diff)

When two users are working on the same book there is the possibility that one of them could delete a frame while the other one is moving it.

Both changes enter the server database - the parent assertion exception is throw. At this point the server could no longer be used and the database should be removed.

Attachments

change-deleted-element.patch (15.9 KB) - added by mira 15 years ago.

Change History

comment:1 Changed 15 years ago by mira

  • Design_owners set to mira
  • Status changed from new to s1b_analysis_finished
  • Description modified (diff)

comment:2 Changed 15 years ago by mira

  • Status changed from s1b_analysis_finished to s2a_design_started

comment:3 Changed 15 years ago by mira

  • Status changed from s2a_design_started to s2b_design_finished

There is a test that demostrates this bug for pages. It showed that the problem was not in the colaboration of the threads nut with the work of the dao itself. There is a bug with the query used to get the children key value - it always gets all children of all revisions.

The children and root visitors should know the current revision id and give it to the dao. The query that gets the SubEntryNames should be updated - it should check the kind of the children to be not null at the current revision.

comment:4 Changed 15 years ago by mira

  • Status changed from s2b_design_finished to s2c_design_ok

comment:5 Changed 15 years ago by mira

  • Owner set to mira
  • Status changed from s2c_design_ok to s3a_implementation_started

The implementation is done according to the design - there is a patch attached to this ticket.

Changed 15 years ago by mira

comment:6 Changed 15 years ago by mira

  • Status changed from s3a_implementation_started to s3b_implementation_finished
  • Imp._owners set to mira

comment:7 Changed 15 years ago by meddle

  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Analysis_reviewers set to meddle
  • Analysis_score changed from 0 to 3
  • Imp._reviewers set to meddle, todor, deyan
  • Design_score changed from 0 to 4
  • Design_reviewers set to meddle
  • Imp._score changed from 0 to 4
  • Please mention the test classes in the future.
  • I don't think that making public method just for testing is good practice, but in this case this doesn't matter.

Merged to the trunk at [8808]

comment:8 Changed 13 years ago by meddle

  • Status changed from s3c_implementation_ok to closed
  • Resolution set to obsolete

Closing all the tickets before M Y1

Note: See TracTickets for help on using tickets.