Ticket #2383 (closed bug: obsolete)

Opened 15 years ago

Last modified 13 years ago

templates-options-lost-on-save

Reported by: deni Owned by: boyanl
Priority: major Milestone:
Component: uncategorized Version: 2.0
Keywords: Cc:
Category: unknown Effort:
Importance: Ticket_group:
Estimated Number of Hours: 0 Add Hours to Ticket: 0
Billable?: yes Total Hours: 0
Analysis_owners: deni Design_owners: boyanl
Imp._owners: boyanl Test_owners:
Analysis_reviewers: boyanl Changelog: Changelog
Design_reviewers: meddle Imp._reviewers: meddle, todor, deyan
Test_reviewers: Analysis_score: 3.5
Design_score: 4 Imp._score: 3.5
Test_score: 0

Description (last modified by deni) (diff)

The options whether to include a given frame/page property in a template are not persisted.

Steps to reproduce (just an example):

  1. Create a new book, insert a frame and click on the 'Add as Template' halo.
  2. Uncheck the 'main-resource' checkbox and save the template.
  3. Save the book.
  4. Open it from the file system.
  5. Insert a new image frame and apply the template created in step (2) to it. Notice that the main resource of the frame will be changed to the text. In this case the main resource should not be changed.

Attachments

templatespersistence.patch​ (5.9 KB) - added by boyanl 15 years ago.

Change History

comment:1 Changed 15 years ago by deni

  • Status changed from new to s1b_analysis_finished
  • Description modified (diff)

comment:2 Changed 15 years ago by deni

  • I tried to fix this in #2351, but I failed. See its implementation notes for details why.

comment:3 Changed 15 years ago by todor

  • Status changed from s1b_analysis_finished to closed
  • Resolution set to invalid

comment:4 Changed 15 years ago by todor

  • Status changed from closed to new
  • Resolution invalid deleted

comment:5 Changed 15 years ago by todor

  • Status changed from new to s1b_analysis_finished

closed by mistake

comment:6 Changed 15 years ago by boyanl

  • Design_owners set to boyanl
  • Status changed from s1b_analysis_finished to s2a_design_started
  • Imp._owners set to boyanl
  • Analysis_score changed from 0 to 3.5

The analysis was clear enough for the task.

comment:7 Changed 15 years ago by boyanl

  • Status changed from s2a_design_started to s2b_design_finished
  • Add a List<Key<?>> getSubkeys () method in Key, which returns the "sub-keys" that should be persisted along with this one.
  • Modify ResourceInfoProvider.getKeysByReflection to include in the list the keys returned by the getSubkeys method too.
  • Add a SimpleSubKey class which represents a simple key, which is a sub-key of another one (with a different persist method)
  • Change KEY_APPLY and KEY_LOCKED in TemplatedKey to be SimpleSubKeys

Changed 15 years ago by boyanl

comment:8 Changed 15 years ago by boyanl

  • Status changed from s2b_design_finished to s2c_design_ok

comment:9 Changed 15 years ago by boyanl

  • Owner set to boyanl
  • Status changed from s2c_design_ok to s3a_implementation_started

comment:10 Changed 15 years ago by boyanl

  • Status changed from s3a_implementation_started to s3b_implementation_finished

comment:11 Changed 15 years ago by meddle

  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Analysis_reviewers set to boyanl
  • Imp._reviewers set to meddle, todor, deyan
  • Design_score changed from 0 to 4
  • Design_reviewers set to meddle
  • Imp._score changed from 0 to 3.5

Merged into the trunk at [9098] and [9099].

comment:12 Changed 13 years ago by meddle

  • Status changed from s3c_implementation_ok to closed
  • Resolution set to obsolete

Closing all the tickets before M Y1

Note: See TracTickets for help on using tickets.