Ticket #2387 (closed bug: obsolete)

Opened 10 years ago

Last modified 9 years ago

autochain-wrapping – Autochaining does not respect wrapping mode

Reported by: deyan Owned by: stefan
Priority: major Milestone: X3
Component: uncategorized Version: 2.0
Keywords: Cc:
Category: unknown Effort:
Importance: Ticket_group:
Estimated Number of Hours: 0 Add Hours to Ticket: 0
Billable?: yes Total Hours: 0
Analysis_owners: deyan Design_owners: stefan
Imp._owners: stefan Test_owners:
Analysis_reviewers: stefan Changelog: Changelog
Design_reviewers: pap Imp._reviewers: pap, todor, pap, todor
Test_reviewers: Analysis_score: 3
Design_score: 3 Imp._score: 4
Test_score: 0

Description (last modified by deyan) (diff)

Create some frames with different wrap modes, create an autochain and note that all modes on new pages are set to no wrap. Wrapping should be preserved in autochains and in frame templates (a checkbox should be present).

Attachments

2387.patch (1.7 KB) - added by stefan 10 years ago.
2387_im.patch (1.4 KB) - added by stefan 10 years ago.

Change History

comment:1 Changed 10 years ago by deyan

  • Status changed from new to s1b_analysis_finished
  • Description modified (diff)
  • Analysis_score set to 0
  • Test_score set to 0
  • Design_score set to 0
  • Imp._score set to 0

comment:2 follow-up: ↓ 5 Changed 10 years ago by stefan

  • Status changed from s1b_analysis_finished to s2a_design_started
  • Analysis_score changed from 0 to 3

comment:3 Changed 10 years ago by stefan

  • Status changed from s2a_design_started to s3b_implementation_finished

KEY_WRAP becomes TemplatedKey - it solves the whole bug (it fixes the autochaining and the checkbox in the TemplateDialog:

public static final TemplatedKey<WrappingModes> KEY_WRAP = new TemplatedKey<WrappingModes>( 
		"resource-wrap", WrappingModes.class, WrappingModes.NO_WRAP) {
	@Override
	public void persistR3(org.sophie2.base.persistence.ref.ValueRef<WrappingModes> ref, Storage destination, PersistenceOptions options, String format) throws IOException {
		MasterPersister.persist(ref, destination.child("resource-wrap"), options,
				PersistenceUtil.getStorageSchema(WrappingModes.class, format));
	}
}; 

comment:4 Changed 10 years ago by stefan

  • Design_owners set to stefan
  • Imp._owners set to stefan
  • Analysis_reviewers set to stefan

comment:5 in reply to: ↑ 2 Changed 10 years ago by stefan

Replying to stefan:
analysis is not detailed, but good enough.

Changed 10 years ago by stefan

comment:6 Changed 10 years ago by pap

  • Status changed from s3b_implementation_finished to s2c_design_ok
  • Design_score changed from 0 to 3
  • Design_reviewers set to pap
  • Imp._score changed from 0 to 2
  • Imp._reviewers set to pap, todor
  • First there is no need of overriding the persistR3 method of the templated key.
  • If you create two frames, one with text and another in front of the first and you enable the wrapping around the second, and then choose autochain for the first, when you try to save the book exception occurs.

comment:7 Changed 10 years ago by stefan

  • Owner set to stefan
  • Status changed from s2c_design_ok to s3a_implementation_started

comment:8 Changed 10 years ago by stefan

  • Status changed from s3a_implementation_started to s3b_implementation_finished

problem described in the review was not related to this ticked. There was suspicion that there is another problem, but nor the analyzer, nor the integrator, neither I could found it. So, I'm putting the task to im_fin phase.

Changed 10 years ago by stefan

comment:9 Changed 10 years ago by meddle

  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Imp._score changed from 2 to 4
  • Imp._reviewers changed from pap, todor to pap, todor, pap, todor

Merged into the trunk at [9030].

comment:10 Changed 9 years ago by meddle

  • Status changed from s3c_implementation_ok to closed
  • Resolution set to obsolete

Closing all the tickets before M Y1

Note: See TracTickets for help on using tickets.