remove-orientation-sub-hud

[dido]

The goal of this task is to optimize the usage of orientation functionality

• In order to reduce users clicks for rotating by pointing the rotation pivot - remove the orientation sub hud and add this functionality to properties hud.
• Use the logic from rotation sub hud instead of the one that exist in properties hud.
• In order to customize the control for rotation pivot, replace check-boxes that are currently used with LogicR3TougleButtons, and rewrite the logic.
• The end result should look as close as possible to the attached image

[dido]

• All toggle buttons that are used to set the rotation position are now part of RotationPivotButtonsContainer sub class inside ProppertiesHud.
• New enumeration EventIds is added.
• Inside the HudLogic
  • New handler is added ON_ROTATION_PIVOT_SET
  • ON_ANGLE_SUBMIT is changed to work as it was working in orientation sub hud. In order to do so there are few support methods added to the hud.
    • getFrameView - Gets the frame view which rotation properties should be changed by this
    • getHud - Helper method to get the related PropertiesHud
    • getModel - Helper method to get the frame model they are working on, for all elements in this hud.
  • Also few new properties are added
    • model - Frame this Hud operates on.
    • rotationPosition - The position in the frame of its rotation center.
    • rotationCenter - The rotation center of the frame this hud is working on.
  • From RotationAngle sub class the method getHud is removed
• OrientationSubHud is removed and the MainAppHalosModule is edited in order to not use the class
• FrameRotationHaloButton now get his rotation pivot position form PropertiesHud instead of OrientationSubHud
• There were some commented code inside this classes, now it's removed
• new assets are added inside org.sophie2.main.app.halos/src/main/resources/distrib/icons/propertiesHud/
• Inside the implementation - new container will be added, that contains RotationPivotButtonsContainer and RotationAngle. They will also swap places, and the gaps between them will be changed.

Note: Forgot to add comment when created the branch

Follow the the link to the design.

[pap]

• I see improvements in your skills :))
• ON_ROTATION_PIVOT_SET is not a nice name for an event. This is the name of an event handler. SET_ROTATION_PIVOT is better.
• The new getHud method has improper JavaDoc. Also I think we don't need it as it only wraps one method.
• I don't think that we really need the model property. Also the getModel method should return something like "hud.context().get(0).model().get()" in order to keep consistency of the model of the hud.
• Also it needs not be a FrameH. ElementH is sufficient I think.
• I think that the map between positions and buttons in RotationPivotButtonsContainer.swingComponent can be ommited if you override the computeSelected method of the concrete buttons. Actually you have overriden that method.
• This makes the separate properties for all the buttons obsolete.
• In the ON_ANGLE_SUBMIT use the getModel method of the PropertiesHud instead of getting the model this way.

[dido]

All issues are fixed here.

[pap]

• Commited in [9100]
• You had incorrect tooltips in the buttons for different positions. This is quite strange for someone in the experience team.
• Don't use the static method BaseVisualElement.findParentElement(locating, class) when inside a visual element.

[meddle]

Closing all the tickets before M Y1