Ticket #2419 (closed bug: obsolete)

Opened 9 years ago

Last modified 8 years ago

[text] Aligment is not correct in empty text frames

Reported by: deyan Owned by:
Priority: major Milestone: X3
Component: uncategorized Version: 2.0
Keywords: Cc:
Category: unknown Effort:
Importance: 86 Ticket_group: text
Estimated Number of Hours: 0 Add Hours to Ticket: 0
Billable?: yes Total Hours: 0
Analysis_owners: deyan Design_owners: diana
Imp._owners: diana Test_owners:
Analysis_reviewers: Changelog: Changelog
Design_reviewers: pap Imp._reviewers: deyan, pap
Test_reviewers: Analysis_score: 0
Design_score: 4 Imp._score: 4
Test_score: 0

Description (last modified by deyan) (diff)

Aligment is not correct in empty text.

  • When aligment is set to left, the cursor should be put at the most left position
  • When aligment is set to right, the cursor should be put at the most right position of the frame
  • When aligment is set to center, the cursor should be put at the center of the frame

Attachments

2419.patch (17.9 KB) - added by diana 9 years ago.

Change History

comment:1 Changed 9 years ago by deyan

  • Status changed from new to s1b_analysis_finished

comment:2 Changed 9 years ago by kyli

  • Ticket_group set to text

comment:3 Changed 9 years ago by deyan

  • Importance set to 92

Batch update from file priorities8.csv

comment:4 Changed 9 years ago by deyan

  • Description modified (diff)
  • Summary changed from [text] Aligment throws exception when cursor is at last position to [text] Aligment is not correct in empty text frames

comment:5 Changed 9 years ago by deyan

  • Importance changed from 92 to 86

comment:6 Changed 9 years ago by diana

  • Design_owners set to diana
  • Status changed from s1b_analysis_finished to s2a_design_started
  • Imp._owners set to diana
  • In HotSegmentLayout:draw if the current style is italics then the caret is drawn in italics style (the upper point x and the bottom point x are not the same).
  • In ImmTextUtils change the createDefaultText to take HotStyleDef (the style to be applied to the DOC_BREAK, needed to take the FONT_SIZE from it and draw the proper caret shape in the layout).
  • In BaseTextModel:updateSelectionOptions take the previous unit style, derive it with the inputStyle() and create new caret options with this HotStyleDef(needed to refresh the caret size when the input style is changed).
  • In CaretOptions class make a new private final HotStyleDef caretStyle - keeps the current style of the caret.
  • In CaretOptions make a getter for the new field.
  • In CaretOptions:hashCode and equals consider the new style def while creating the hashCode or comparing the object.
  • In CaretProcessor:getStyledText change the style of the DOC_BREAK and the caret options' style with the style from the last character derived with the given options' one.
  • In TextModelLogic:ON_APPLY_PARA_STYLE set new caret options if there is no selected interval.

Changed 9 years ago by diana

comment:7 Changed 9 years ago by diana

  • Status changed from s2a_design_started to s3b_implementation_finished

comment:8 Changed 9 years ago by pap

  • Status changed from s3b_implementation_finished to s3c_implementation_ok
  • Design_score changed from 0 to 4
  • Design_reviewers set to pap
  • Imp._score changed from 0 to 4
  • Imp._reviewers set to deyan, pap
  • Committed in [9228].
  • No serious remarks.
  • You didn't make an analysis review.

comment:9 Changed 8 years ago by meddle

  • Status changed from s3c_implementation_ok to closed
  • Resolution set to obsolete

Closing all the tickets before M Y1

Note: See TracTickets for help on using tickets.